From: David Miller <davem@davemloft.net>
To: calvin.johnson@oss.nxp.com
Cc: grant.likely@arm.com, rafael@kernel.org, jeremy.linton@arm.com,
andrew@lunn.ch, andy.shevchenko@gmail.com, f.fainelli@gmail.com,
linux@armlinux.org.uk, cristian.sovaiala@nxp.com,
florinlaurentiu.chiculita@nxp.com, ioana.ciornei@nxp.com,
madalin.bucur@oss.nxp.com, heikki.krogerus@linux.intel.com,
linux-kernel@vger.kernel.org, linux.cj@gmail.com,
netdev@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, diana.craciun@nxp.com,
laurentiu.tudor@nxp.com, hkallweit1@gmail.com, kuba@kernel.org
Subject: Re: [net-next PATCH v1 2/7] net: phy: Introduce phy related fwnode functions
Date: Wed, 30 Sep 2020 15:03:49 -0700 (PDT) [thread overview]
Message-ID: <20200930.150349.1490001851325231827.davem@davemloft.net> (raw)
In-Reply-To: <20200930160430.7908-3-calvin.johnson@oss.nxp.com>
From: Calvin Johnson <calvin.johnson@oss.nxp.com>
Date: Wed, 30 Sep 2020 21:34:25 +0530
> +struct phy_device *fwnode_phy_find_device(struct fwnode_handle *phy_fwnode)
> +{
> + struct device *d;
> + struct mdio_device *mdiodev;
Please use reverse christmas tree ordering for local variables.
next prev parent reply other threads:[~2020-09-30 22:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 16:04 [net-next PATCH v1 0/7] ACPI support for dpaa2 driver Calvin Johnson
2020-09-30 16:04 ` [net-next PATCH v1 1/7] Documentation: ACPI: DSD: Document MDIO PHY Calvin Johnson
2020-09-30 16:37 ` Rafael J. Wysocki
2020-10-01 13:26 ` Calvin Johnson
2020-10-02 11:08 ` Grant Likely
2020-10-02 14:13 ` Rafael J. Wysocki
2020-09-30 16:04 ` [net-next PATCH v1 2/7] net: phy: Introduce phy related fwnode functions Calvin Johnson
2020-09-30 22:03 ` David Miller [this message]
2020-10-01 3:58 ` Calvin Johnson
2020-09-30 16:04 ` [net-next PATCH v1 3/7] net: phy: Introduce fwnode_get_phy_id() Calvin Johnson
2020-09-30 16:34 ` Andrew Lunn
2020-09-30 18:07 ` Russell King - ARM Linux admin
2020-09-30 18:19 ` Andrew Lunn
2020-10-01 4:00 ` Calvin Johnson
2020-10-02 10:48 ` Grant Likely
2020-10-02 11:05 ` Grant Likely
2020-10-02 15:14 ` Florian Fainelli
2020-10-02 15:50 ` Russell King - ARM Linux admin
2020-10-03 18:03 ` Calvin Johnson
2020-10-03 18:00 ` Calvin Johnson
2020-09-30 16:04 ` [net-next PATCH v1 4/7] net: mdiobus: Introduce fwnode_mdiobus_register_phy() Calvin Johnson
2020-09-30 22:04 ` David Miller
2020-09-30 16:04 ` [net-next PATCH v1 5/7] phylink: introduce phylink_fwnode_phy_connect() Calvin Johnson
2020-09-30 16:04 ` [net-next PATCH v1 6/7] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson
2020-10-01 15:36 ` Andy Shevchenko
2020-10-03 16:30 ` Calvin Johnson
2020-10-02 11:22 ` Grant Likely
2020-10-03 17:39 ` Calvin Johnson
2020-10-07 15:50 ` Calvin Johnson
2020-09-30 16:04 ` [net-next PATCH v1 7/7] net/fsl: Use _ADR ACPI object to register PHYs Calvin Johnson
2020-09-30 16:27 ` Andrew Lunn
2020-09-30 22:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930.150349.1490001851325231827.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=calvin.johnson@oss.nxp.com \
--cc=cristian.sovaiala@nxp.com \
--cc=diana.craciun@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=florinlaurentiu.chiculita@nxp.com \
--cc=grant.likely@arm.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jeremy.linton@arm.com \
--cc=kuba@kernel.org \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).