* [PATCH -next] mm/vmscan: Drop duplicated code in drop_slab_node
@ 2020-09-30 2:06 Kefeng Wang
2020-09-30 2:42 ` [External] " Chunxin Zang
0 siblings, 1 reply; 2+ messages in thread
From: Kefeng Wang @ 2020-09-30 2:06 UTC (permalink / raw)
To: Andrew Morton, linux-mm; +Cc: linux-kernel, Kefeng Wang, Chunxin Zang
The following patches fix same issue and both add fatal
signal check in drop_slab_node, kill a duplicated check.
"mm/vmscan: add a fatal signals check in drop_slab_node"
"mm/vmscan: fix infinite loop in drop_slab_node"
Cc: Chunxin Zang <zangchunxin@bytedance.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
mm/vmscan.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index eae57d092931..980155e257bf 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -699,9 +699,6 @@ void drop_slab_node(int nid)
do {
struct mem_cgroup *memcg = NULL;
- if (fatal_signal_pending(current))
- return;
-
if (fatal_signal_pending(current))
return;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [External] [PATCH -next] mm/vmscan: Drop duplicated code in drop_slab_node
2020-09-30 2:06 [PATCH -next] mm/vmscan: Drop duplicated code in drop_slab_node Kefeng Wang
@ 2020-09-30 2:42 ` Chunxin Zang
0 siblings, 0 replies; 2+ messages in thread
From: Chunxin Zang @ 2020-09-30 2:42 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux Memory Management List, LKML, Kefeng Wang, Hocko
On Wed, Sep 30, 2020 at 10:07 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
> The following patches fix same issue and both add fatal
> signal check in drop_slab_node, kill a duplicated check.
>
> "mm/vmscan: add a fatal signals check in drop_slab_node"
> "mm/vmscan: fix infinite loop in drop_slab_node"
>
> Cc: Chunxin Zang <zangchunxin@bytedance.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> mm/vmscan.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index eae57d092931..980155e257bf 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -699,9 +699,6 @@ void drop_slab_node(int nid)
> do {
> struct mem_cgroup *memcg = NULL;
>
> - if (fatal_signal_pending(current))
> - return;
> -
> if (fatal_signal_pending(current))
> return;
>
> --
> 2.26.2
>
Yes, there are the same patch. Because the 'add a fatal signals
check in drop_slab_node' description is more accurate.
The mail list please see https://lkml.org/lkml/2020/9/15/20
Andrew, can you update it , thanks so much.
Best wishes
Chunxin Zang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-30 2:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-30 2:06 [PATCH -next] mm/vmscan: Drop duplicated code in drop_slab_node Kefeng Wang
2020-09-30 2:42 ` [External] " Chunxin Zang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).