From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D9FFC4727C for ; Wed, 30 Sep 2020 02:01:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E93EC20B1F for ; Wed, 30 Sep 2020 02:01:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729643AbgI3CBJ (ORCPT ); Tue, 29 Sep 2020 22:01:09 -0400 Received: from mxout03.lancloud.ru ([89.108.73.187]:60778 "EHLO mxout03.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729322AbgI3CBJ (ORCPT ); Tue, 29 Sep 2020 22:01:09 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru D1731206E427 Received: from LanCloud Received: from LanCloud Received: from LanCloud Date: Wed, 30 Sep 2020 05:01:01 +0300 From: Elvira Khabirova To: Jens Wiklander CC: , , , , Subject: Re: [RFC PATCH] tee: add support for application-based session login methods Message-ID: <20200930050101.034762a7@akathisia> In-Reply-To: <20200928134347.GA76106@jade> References: <20200917183803.4a0c5263@akathisia> <20200928134347.GA76106@jade> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [89.255.69.56] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1903.lancloud.ru (fd00:f066::73) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Sep 2020 15:43:47 +0200 Jens Wiklander wrote: > Hi Elvira, > > On Thu, Sep 17, 2020 at 06:38:03PM +0300, Elvira Khabirova wrote: > > GP TEE Client API in addition to login methods already supported > > in the kernel also defines several application-based methods: > > TEEC_LOGIN_APPLICATION, TEEC_LOGIN_USER_APPLICATION, and > > TEEC_LOGIN_GROUP_APPLICATION. > > > > It specifies credentials generated for TEEC_LOGIN_APPLICATION as only > > depending on the identity of the program, being persistent within one > > implementation, across multiple invocations of the application > > and across power cycles, enabling them to be used to disambiguate > > persistent storage. The exact nature is REE-specific. > > > > As the exact method of generating application identifier strings may > > vary between vendors, setups and installations, add two suggested > > methods and an exact framework for vendors to extend upon. > > > > Signed-off-by: Elvira Khabirova > > --- > > drivers/tee/Kconfig | 29 +++++++++ > > drivers/tee/tee_core.c | 136 ++++++++++++++++++++++++++++++++++++++++- > > 2 files changed, 164 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/tee/Kconfig b/drivers/tee/Kconfig > > index e99d840c2511..4cd6e0d2aad5 100644 > > --- a/drivers/tee/Kconfig > > +++ b/drivers/tee/Kconfig > > @@ -11,6 +11,35 @@ config TEE > > This implements a generic interface towards a Trusted Execution > > Environment (TEE). > > > > +choice > > + prompt "Application ID for client UUID" > > + depends on TEE > > + default TEE_APPID_PATH > > + help > > + This option allows to choose which method will be used to generate > > + application identifiers for client UUID generation when login methods > > + TEE_LOGIN_APPLICATION, TEE_LOGIN_USER_APPLICATION > > + and TEE_LOGIN_GROUP_APPLICATION are used. > > + Please be mindful of the security of each method in your particular > > + installation. > > + > > + config TEE_APPID_PATH > > + bool "Path-based application ID" > > + help > > + Use the executable's path as an application ID. > > + > > + config TEE_APPID_SECURITY > > + bool "Security extended attribute based application ID" > > + help > > + Use the executable's security extended attribute as an application ID. > > +endchoice > > + > > +config TEE_APPID_SECURITY_XATTR > > + string "Security extended attribute to use for application ID" > > + depends on TEE_APPID_SECURITY > > + help > > + Attribute to be used as an application ID (with the security prefix removed). > > + > > if TEE > > > > menu "TEE drivers" > > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c > > index 64637e09a095..19c965dd212b 100644 > > --- a/drivers/tee/tee_core.c > > +++ b/drivers/tee/tee_core.c > > @@ -7,8 +7,10 @@ > > > > #include > > #include > > +#include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -17,11 +19,15 @@ > > #include > > #include "tee_private.h" > > > > +#ifdef CONFIG_TEE_APPID_SECURITY > No need for the ifdef, just inlude the file unconditionally above. > > > +#include > > +#endif > > + > > #define TEE_NUM_DEVICES 32 > > > > #define TEE_IOCTL_PARAM_SIZE(x) (sizeof(struct tee_param) * (x)) > > > > -#define TEE_UUID_NS_NAME_SIZE 128 > > +#define TEE_UUID_NS_NAME_SIZE PATH_MAX > > > > /* > > * TEE Client UUID name space identifier (UUIDv4) > > @@ -125,6 +131,67 @@ static int tee_release(struct inode *inode, struct file *filp) > > return 0; > > } > > > > +#ifdef CONFIG_TEE_APPID_SECURITY > > +static const char *tee_session_get_application_id(void **data) > static char *get_app_id(void) should be enough. > > > +{ > > + struct file *exe_file; > > + const char *name = CONFIG_TEE_APPID_SECURITY_XATTR; > > + int len; > > + > > + exe_file = get_mm_exe_file(current->mm); > > + if (!exe_file) > > + return ERR_PTR(-ENOENT); > > + > > + if (!exe_file->f_inode) { > > + fput(exe_file); > > + return ERR_PTR(-ENOENT); > > + } > > + > > You could perhaps add a comment here on the expected properties of this > data. Something along (don't know if I'm even close) "string > representation of the the hash of the binary and time stamp". > > > + len = security_inode_getsecurity(exe_file->f_inode, name, data, true); > > + if (len < 0) > > + return ERR_PTR(len); > > + > > + fput(exe_file); > > + > > + return *data; > > +} > > +#endif /* CONFIG_TEE_APPID_SECURITY */ > > + > > +#ifdef CONFIG_TEE_APPID_PATH > > +static const char *tee_session_get_application_id(void **data) > > +{ > > + struct file *exe_file; > > + char *path; > > + > > + *data = kzalloc(TEE_UUID_NS_NAME_SIZE, GFP_KERNEL); > > + if (!*data) > > + return ERR_PTR(-ENOMEM); > > + > > + exe_file = get_mm_exe_file(current->mm); > > + if (!exe_file) { > > + kfree(*data); > > + return ERR_PTR(-ENOENT); > > + } > > + > > + path = file_path(exe_file, *data, TEE_UUID_NS_NAME_SIZE); > > + if (IS_ERR(path)) { > > + kfree(*data); > > + return path; > > + } > > + > > + fput(exe_file); > > + > > + return path; > > +} > > +#endif /* CONFIG_TEE_APPID_PATH */ > > + > > +#if defined(CONFIG_TEE_APPID_PATH) || defined(CONFIG_TEE_APPID_SECURITY) > > +static void tee_session_free_application_id(void *data) > > +{ > > + kfree(data); > > +} > This function isn't needed, we can call kfree() directly. > > > +#endif /* CONFIG_TEE_APPID_PATH || CONFIG_TEE_APPID_SECURITY */ > > + > > /** > > * uuid_v5() - Calculate UUIDv5 > > * @uuid: Resulting UUID > > @@ -197,6 +264,8 @@ int tee_session_calc_client_uuid(uuid_t *uuid, u32 connection_method, > > gid_t ns_grp = (gid_t)-1; > > kgid_t grp = INVALID_GID; > > char *name = NULL; > > + void *application_id_data = NULL; > This isn't needed The only reason application_id_data exists (and get_application_id has a parameter) is because when defined(CONFIG_TEE_APPID_PATH), file_path() returns a pointer that often starts at an offset into the buffer (see the comment above d_path()). Therefore we end up with a buffer that's not equal to application_id which we want to free later. The other way (other than having a void **data parameter) would be to allocate a new buffer, copy the resulting path there, and return the new buffer instead of the one used by file_path(). Let me know which solution is preferred. > > + const char *application_id = NULL; > char *app_id = NULL; > > > int name_len; > > int rc; > > > > @@ -217,6 +286,14 @@ int tee_session_calc_client_uuid(uuid_t *uuid, u32 connection_method, > > * For TEEC_LOGIN_GROUP: > > * gid= > > * > > + * For TEEC_LOGIN_APPLICATION: > > + * app= > > + * > > + * For TEEC_LOGIN_USER_APPLICATION: > > + * uid=:app= > > + * > > + * For TEEC_LOGIN_GROUP_APPLICATION: > > + * gid=:app= > > */ > > > > name = kzalloc(TEE_UUID_NS_NAME_SIZE, GFP_KERNEL); > > @@ -249,6 +326,63 @@ int tee_session_calc_client_uuid(uuid_t *uuid, u32 connection_method, > > } > > break; > > > > + case TEE_IOCTL_LOGIN_APPLICATION: > > + application_id = tee_session_get_application_id(&application_id_data); > > + if (IS_ERR(application_id)) { > > + rc = PTR_ERR(application_id); > > + goto out_free_name; > > + } > > + > > + name_len = snprintf(name, TEE_UUID_NS_NAME_SIZE, "app=%s", > > + application_id); > > + tee_session_free_application_id(application_id_data); > > + > > + if (name_len >= TEE_UUID_NS_NAME_SIZE) { > > + rc = -E2BIG; > > + goto out_free_name; > > + } > It looks like we remove these tests and replace them with > if (name_len < TEE_UUID_NS_NAME_SIZE) > rc = uuid_v5(uuid, &tee_client_uuid_ns, name, name_len); > else > rc = -E2BIG > > below, just above the "out_free_name:" label. > > This function is small and simple enough that it should be easy to see > what's going on any way. > > Thanks, > Jens > > > + break; > > + > > + case TEE_IOCTL_LOGIN_USER_APPLICATION: > > + application_id = tee_session_get_application_id(&application_id_data); > > + if (IS_ERR(application_id)) { > > + rc = PTR_ERR(application_id); > > + goto out_free_name; > > + } > > + > > + name_len = snprintf(name, TEE_UUID_NS_NAME_SIZE, "uid=%x:app=%s", > > + current_euid().val, application_id); > > + tee_session_free_application_id(application_id_data); > > + > > + if (name_len >= TEE_UUID_NS_NAME_SIZE) { > > + rc = -E2BIG; > > + goto out_free_name; > > + } > > + break; > > + > > + case TEE_IOCTL_LOGIN_GROUP_APPLICATION: > > + memcpy(&ns_grp, connection_data, sizeof(gid_t)); > > + grp = make_kgid(current_user_ns(), ns_grp); > > + if (!gid_valid(grp) || !in_egroup_p(grp)) { > > + rc = -EPERM; > > + goto out_free_name; > > + } > > + > > + application_id = tee_session_get_application_id(&application_id_data); > > + if (IS_ERR(application_id)) { > > + rc = PTR_ERR(application_id); > > + goto out_free_name; > > + } > > + name_len = snprintf(name, TEE_UUID_NS_NAME_SIZE, "gid=%x:app=%s", > > + grp.val, application_id); > > + tee_session_free_application_id(application_id_data); > > + > > + if (name_len >= TEE_UUID_NS_NAME_SIZE) { > > + rc = -E2BIG; > > + goto out_free_name; > > + } > > + break; > > + > > default: > > rc = -EINVAL; > > goto out_free_name; > > -- > > 2.28.0 > >