From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64F47C4727E for ; Wed, 30 Sep 2020 11:39:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD8FF2076B for ; Wed, 30 Sep 2020 11:39:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ZmToCpHo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729205AbgI3LjK (ORCPT ); Wed, 30 Sep 2020 07:39:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727426AbgI3LjK (ORCPT ); Wed, 30 Sep 2020 07:39:10 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9A43C061755; Wed, 30 Sep 2020 04:39:09 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 351EF329; Wed, 30 Sep 2020 13:39:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1601465947; bh=NlkpR2LFs4KY8D3VqPxO2wXjCGvxAaEzMycLRaNUtBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZmToCpHo5ZPwxdNEvbu6XMMlELyfrHppj87odoQUqCjyoNpxwMDZBTL4AHFoHokOC lmD9g5uGGSTJrWYR8gFElp/cyfswxjpqq9Z1rGYLPDfYm+oke3RDtqyQ4LRJhMAF9o Rd/CtEICIZuijpHBox4rh849LODCX3KuMlMn+xE0= Date: Wed, 30 Sep 2020 14:38:31 +0300 From: Laurent Pinchart To: Stefan Riedmueller Cc: Mauro Carvalho Chehab , Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Enrico Scholz Subject: Re: [PATCH v2 3/5] media: mt9p031: Implement [gs]_register debug calls Message-ID: <20200930113831.GG5689@pendragon.ideasonboard.com> References: <20200930105133.139981-1-s.riedmueller@phytec.de> <20200930105133.139981-3-s.riedmueller@phytec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200930105133.139981-3-s.riedmueller@phytec.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stefan, Thank you for the patch. On Wed, Sep 30, 2020 at 12:51:31PM +0200, Stefan Riedmueller wrote: > From: Enrico Scholz > > Implement g_register and s_register v4l2_subdev_core_ops to access > camera register directly from userspace for debug purposes. As the name of the operations imply, this is meant for debug purpose only. They are however prone to be abused to configure the sensor from userspace in production, which isn't a direction we want to take. What's your use case for this ? I'd rather drop this patch and see the driver extended with support for more controls if needed > Signed-off-by: Enrico Scholz > Signed-off-by: Stefan Riedmueller > --- > No changes in v2 > --- > drivers/media/i2c/mt9p031.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c > index b4c042f418c1..de36025260a8 100644 > --- a/drivers/media/i2c/mt9p031.c > +++ b/drivers/media/i2c/mt9p031.c > @@ -703,6 +703,30 @@ static int mt9p031_restore_blc(struct mt9p031 *mt9p031) > return 0; > } > > +#ifdef CONFIG_VIDEO_ADV_DEBUG > +static int mt9p031_g_register(struct v4l2_subdev *sd, > + struct v4l2_dbg_register *reg) > +{ > + struct i2c_client *client = v4l2_get_subdevdata(sd); > + int ret; > + > + ret = mt9p031_read(client, reg->reg); > + if (ret < 0) > + return ret; > + > + reg->val = ret; > + return 0; > +} > + > +static int mt9p031_s_register(struct v4l2_subdev *sd, > + struct v4l2_dbg_register const *reg) > +{ > + struct i2c_client *client = v4l2_get_subdevdata(sd); > + > + return mt9p031_write(client, reg->reg, reg->val); > +} > +#endif > + > static int mt9p031_s_ctrl(struct v4l2_ctrl *ctrl) > { > struct mt9p031 *mt9p031 = > @@ -1000,6 +1024,10 @@ static int mt9p031_close(struct v4l2_subdev *subdev, struct v4l2_subdev_fh *fh) > > static const struct v4l2_subdev_core_ops mt9p031_subdev_core_ops = { > .s_power = mt9p031_set_power, > +#ifdef CONFIG_VIDEO_ADV_DEBUG > + .s_register = mt9p031_s_register, > + .g_register = mt9p031_g_register, > +#endif > }; > > static const struct v4l2_subdev_video_ops mt9p031_subdev_video_ops = { -- Regards, Laurent Pinchart