From: Johannes Weiner <hannes@cmpxchg.org>
To: Roman Gushchin <guro@fb.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Shakeel Butt <shakeelb@google.com>,
Michal Hocko <mhocko@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kernel-team@fb.com
Subject: Re: [PATCH v3 4/4] mm: convert page kmemcg type to a page memcg flag
Date: Wed, 30 Sep 2020 17:01:24 -0400 [thread overview]
Message-ID: <20200930210124.GB469663@cmpxchg.org> (raw)
In-Reply-To: <20200929235920.537849-5-guro@fb.com>
On Tue, Sep 29, 2020 at 04:59:20PM -0700, Roman Gushchin wrote:
> @@ -3087,7 +3087,7 @@ int __memcg_kmem_charge_page(struct page *page, gfp_t gfp, int order)
> ret = __memcg_kmem_charge(memcg, gfp, 1 << order);
> if (!ret) {
> set_page_memcg(page, memcg);
> - __SetPageKmemcg(page);
> + __SetPageMemcgKmem(page);
> return 0;
> }
> css_put(&memcg->css);
> @@ -3112,10 +3112,6 @@ void __memcg_kmem_uncharge_page(struct page *page, int order)
> __memcg_kmem_uncharge(memcg, nr_pages);
> clear_page_memcg(page);
> css_put(&memcg->css);
> -
> - /* slab pages do not have PageKmemcg flag set */
> - if (PageKmemcg(page))
> - __ClearPageKmemcg(page);
Hm, the named flags are great, and the getter functions are complex
enough to justify helpers.
But both flags are set along with the object pointer, and cleared when
the pointer is cleared (which makes sense, because pages can not
change their type while they're alive). page_clear_memcg() and
page_clear_objcgs() do the same thing.
page->memcg_data = (unsigned long)pointer | MEMCG_DATA_TYPE;
and
page->memcg_data = 0;
are straight-forward and really don't require abstraction. Please
open-code these.
next prev parent reply other threads:[~2020-09-30 21:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 23:59 [PATCH v3 0/4] mm: allow mapping accounted kernel pages to userspace Roman Gushchin
2020-09-29 23:59 ` [PATCH v3 1/4] mm: memcontrol: use helpers to access page's memcg data Roman Gushchin
2020-09-30 20:32 ` Johannes Weiner
2020-09-29 23:59 ` [PATCH v3 2/4] mm: memcontrol/slab: use helpers to access slab page's memcg_data Roman Gushchin
2020-09-29 23:59 ` [PATCH v3 3/4] mm: introduce page memcg flags Roman Gushchin
2020-09-30 23:35 ` Shakeel Butt
2020-09-30 23:44 ` Roman Gushchin
2020-09-29 23:59 ` [PATCH v3 4/4] mm: convert page kmemcg type to a page memcg flag Roman Gushchin
2020-09-30 21:01 ` Johannes Weiner [this message]
2020-09-30 21:06 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930210124.GB469663@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).