From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86CD0C4741F for ; Wed, 30 Sep 2020 22:51:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 489582074A for ; Wed, 30 Sep 2020 22:51:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601506318; bh=KFmouRsvBVZ3Y/PYT9xJnwdLHua2k27n0cu1H9BZ6l8=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=QtghNygir9joC5ZNbMrcQVULv01B4oz7YCEaZYslPgVDg5oELpZ2HCcFFIQbsFtwR 4mE5zqzWgNgdHFc1yspWHZzneRC8fAsMzne0zGPwU0BS0ODe9lsP1Y8zg8b/SsDz3+ 302bNhBFUD0346o5l3753N4VLMW15pOmridIf8bU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731911AbgI3Wv5 (ORCPT ); Wed, 30 Sep 2020 18:51:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:59750 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731808AbgI3Wv4 (ORCPT ); Wed, 30 Sep 2020 18:51:56 -0400 Received: from localhost (170.sub-72-107-125.myvzw.com [72.107.125.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C272F20719; Wed, 30 Sep 2020 22:51:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601506316; bh=KFmouRsvBVZ3Y/PYT9xJnwdLHua2k27n0cu1H9BZ6l8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ErCOiYuE3T/ukx2QVvOYx3P0p85+8zd+cviA6M2gceIzSfDLjPA9npAn6qBYwnZ64 D8WZF8dQV6bbmloxOP+jC9nRt+BSSIUUmr/oIZ34jAPvXpKNwOIl5kUOFbSrvWE/mR Z4k8wm4xr98IWOFHxbMljjMiI7xM95LPcjIeY/qk= Date: Wed, 30 Sep 2020 17:51:54 -0500 From: Bjorn Helgaas To: Rob Herring Cc: Niklas =?iso-8859-1?Q?S=F6derlund?= , Bjorn Helgaas , Marc Zyngier , devicetree@vger.kernel.org, PCI , "open list:ARM/Rockchip SoC..." , linux-arm-kernel , Lorenzo Pieralisi , Heiko Stuebner , Frank Rowand , Shawn Lin , Jiaxun Yang , Android Kernel Team , Samuel Dionne-Riel , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] of: address: Work around missing device_type property in pcie nodes Message-ID: <20200930225154.GA2631019@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2020 at 03:34:10PM -0500, Rob Herring wrote: > On Wed, Sep 30, 2020 at 12:37 PM Niklas Söderlund > wrote: > > > > Hi Marc, > > > > On 2020-09-30 18:23:21 +0100, Marc Zyngier wrote: > > > Hi Niklas, > > > > > > [+ Samuel] > > > > > > On 2020-09-30 17:27, Niklas Söderlund wrote: > > > > Hi Marc, > > > > > > > > I'm afraid this commit breaks booting my rk3399 device. > > > > > > > > I bisected the problem to this patch merged as [1]. I'm testing on a > > > > Scarlet device and I'm using the unmodified upstream > > > > rk3399-gru-scarlet-inx.dtb for my tests. > > > > > > > > The problem I'm experience is a black screen after the bootloader and > > > > the device is none responsive over the network. I have no serial console > > > > to this device so I'm afraid I can't tell you if there is anything > > > > useful on to aid debugging there. > > > > > > > > If I try to test one commit earlier [2] the system boots as expected and > > > > everything works as it did for me in v5.8 and earlier. I have worked > > > > little with this device and have no clue about what is really on the PCI > > > > buss. But running from [2] I have this info about PCI if it's helpful, > > > > please ask if somethings missing. > > > > > > Please see the thread at [1]. The problem was reported a few weeks back > > > by Samuel, and I was expecting Rob and Lorenzo to push a fix for this. > > > > Thanks for providing a solution. > > > > > > > > Rob, Lorenzo, any update on this? > > The fix is in Bjorn's tree[1]. > > Bjorn, going to send this to Linus before v5.9 is out? Definitely, thanks for the reminder. I'm assuming the fix in question is https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=for-linus&id=e338eecf3fe79054e8a31b8c39a1234b5acfdabe > [1] https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=for-linus