From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4590FC4727E for ; Fri, 2 Oct 2020 01:46:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D64D20719 for ; Fri, 2 Oct 2020 01:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387569AbgJBBq2 (ORCPT ); Thu, 1 Oct 2020 21:46:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727780AbgJBBq1 (ORCPT ); Thu, 1 Oct 2020 21:46:27 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8701C0613D0; Thu, 1 Oct 2020 18:46:27 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DA5791285D1B0; Thu, 1 Oct 2020 18:29:39 -0700 (PDT) Date: Thu, 01 Oct 2020 18:46:26 -0700 (PDT) Message-Id: <20201001.184626.136765913718934240.davem@davemloft.net> To: jingxiangfeng@huawei.com Cc: kuba@kernel.org, luc.vanoostenryck@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] caif_virtio: Remove redundant initialization of variable err From: David Miller In-Reply-To: <20200930012954.1355-1-jingxiangfeng@huawei.com> References: <20200930012954.1355-1-jingxiangfeng@huawei.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Thu, 01 Oct 2020 18:29:40 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jing Xiangfeng Date: Wed, 30 Sep 2020 09:29:54 +0800 > After commit a8c7687bf216 ("caif_virtio: Check that vringh_config is not > null"), the variable err is being initialized with '-EINVAL' that is > meaningless. So remove it. > > Signed-off-by: Jing Xiangfeng Applied to net-next.