From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 758B6C47420 for ; Thu, 1 Oct 2020 17:02:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32B76208B6 for ; Thu, 1 Oct 2020 17:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601571746; bh=CT8KJZLhDnaw9uZvQtE+9OTGUmasnl/Zxle8BsB9f7w=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=JsMEEMMeE5X/7yX96lULvqsFqoju0vj+pjNvJQ9MZveYO0sM0QSghp5M0A8SwAzle eWBoI74AtBn+yqSzEInFyz1gHvRqOqlK1bOafjmWQ9SU0Lx0dmO/UFVZAs7779BySB GWb1Sh0BVP/+pIQ1dgs7RqnY4f+fAS0Vl7Mvt//w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732847AbgJARCZ (ORCPT ); Thu, 1 Oct 2020 13:02:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:35606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732159AbgJARCB (ORCPT ); Thu, 1 Oct 2020 13:02:01 -0400 Received: from localhost (170.sub-72-107-125.myvzw.com [72.107.125.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B7304207F7; Thu, 1 Oct 2020 17:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601571721; bh=CT8KJZLhDnaw9uZvQtE+9OTGUmasnl/Zxle8BsB9f7w=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=fP3I5/GQyEn9m52+ewsMNnej5hCiXao7HJd6fAYFB4BKNW4KpIHl1D1v7CN1HaC+e pBLuXi3JRB8IhWkShy07N2vq0WxlePYHj32ZODZ4drP7tTzzTiYTs9yoFrW35g9zuH 6CP1uoNLS5Je6og+MYHL9vjl3P2fqdyOoWN2hL48= Date: Thu, 1 Oct 2020 12:01:59 -0500 From: Bjorn Helgaas To: Qian Cai Cc: Bjorn Helgaas , Puranjay Mohan , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] pci: Fix -Wunused-function warnings for pci_ltr_* Message-ID: <20201001170159.GA2706033@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201001132850.7630-1-cai@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 01, 2020 at 09:28:49AM -0400, Qian Cai wrote: > When CONFIG_PCIEASPM=n, > > drivers/pci/pci.c:3098:12: warning: 'pci_ltr_encode' defined but not used [-Wunused-function] > static u16 pci_ltr_encode(u64 val) > ^~~~~~~~~~~~~~ > drivers/pci/pci.c:3076:12: warning: 'pci_ltr_decode' defined but not used [-Wunused-function] > static u64 pci_ltr_decode(u16 latency) > ^~~~~~~~~~~~~~ > > Fixes: 5ccf2a6e483f ("PCI/ASPM: Add support for LTR _DSM") > Signed-off-by: Qian Cai Fixed, thanks! > --- > drivers/pci/pci.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index db8feb2033e7..e96e5933b371 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -3069,6 +3069,7 @@ void pci_pm_init(struct pci_dev *dev) > dev->imm_ready = 1; > } > > +#ifdef CONFIG_PCIEASPM > /** > * pci_ltr_decode - Decode the latency to a value in ns > * @latency: latency register value according to PCIe r5.0, sec 6.18, 7.8.2 > @@ -3113,7 +3114,6 @@ static u16 pci_ltr_encode(u64 val) > */ > void pci_ltr_init(struct pci_dev *dev) > { > -#ifdef CONFIG_PCIEASPM > int ltr; > struct pci_dev *bridge; > u64 snoop = 0, nosnoop = 0; > @@ -3150,9 +3150,15 @@ void pci_ltr_init(struct pci_dev *dev) > pci_write_config_word(dev, ltr + PCI_LTR_MAX_NOSNOOP_LAT, > nosnoop_enc); > } > -#endif > } > > +#else > +void pci_ltr_init(struct pci_dev *dev) > +{ > +} > + > +#endif > + > static unsigned long pci_ea_flags(struct pci_dev *dev, u8 prop) > { > unsigned long flags = IORESOURCE_PCI_FIXED | IORESOURCE_PCI_EA_BEI; > -- > 2.28.0 >