Hi Henrik, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Henrik-Bjoernlund/net-bridge-cfm-Add-support-for-Connectivity-Fault-Management-CFM/20201001-184031 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git f2e834694b0d92187d889172da842e27829df371 config: c6x-randconfig-r032-20200930 (attached as .config) compiler: c6x-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/1c0b81655468c16fd143f325138a856ca7727071 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Henrik-Bjoernlund/net-bridge-cfm-Add-support-for-Connectivity-Fault-Management-CFM/20201001-184031 git checkout 1c0b81655468c16fd143f325138a856ca7727071 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=c6x If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): In file included from net/bridge/br_private_mrp.h:6, from net/bridge/br_mrp.c:4: >> net/bridge/br_private.h:94:32: warning: 'struct net_bridge_port' declared inside parameter list will not be visible outside of this definition or declaration 94 | int (*frame_handler)(struct net_bridge_port *port, | ^~~~~~~~~~~~~~~ >> net/bridge/br_mrp.c:13:19: error: initialization of 'int (*)(struct net_bridge_port *, struct sk_buff *)' from incompatible pointer type 'int (*)(struct net_bridge_port *, struct sk_buff *)' [-Werror=incompatible-pointer-types] 13 | .frame_handler = br_mrp_process, | ^~~~~~~~~~~~~~ net/bridge/br_mrp.c:13:19: note: (near initialization for 'mrp_frame_type.frame_handler') cc1: some warnings being treated as errors -- In file included from net/bridge/br.c:20: >> net/bridge/br_private.h:94:32: warning: 'struct net_bridge_port' declared inside parameter list will not be visible outside of this definition or declaration 94 | int (*frame_handler)(struct net_bridge_port *port, | ^~~~~~~~~~~~~~~ -- In file included from include/trace/events/bridge.h:10, from net/bridge/br_fdb.c:24: >> include/trace/events/../../../net/bridge/br_private.h:94:32: warning: 'struct net_bridge_port' declared inside parameter list will not be visible outside of this definition or declaration 94 | int (*frame_handler)(struct net_bridge_port *port, | ^~~~~~~~~~~~~~~ -- In file included from net/bridge/br_input.c:23: >> net/bridge/br_private.h:94:32: warning: 'struct net_bridge_port' declared inside parameter list will not be visible outside of this definition or declaration 94 | int (*frame_handler)(struct net_bridge_port *port, | ^~~~~~~~~~~~~~~ net/bridge/br_input.c: In function 'br_process_frame_type': >> net/bridge/br_input.c:267:30: error: passing argument 1 of 'tmp->frame_handler' from incompatible pointer type [-Werror=incompatible-pointer-types] 267 | return tmp->frame_handler(p, skb); | ^ | | | struct net_bridge_port * net/bridge/br_input.c:267:30: note: expected 'struct net_bridge_port *' but argument is of type 'struct net_bridge_port *' cc1: some warnings being treated as errors -- In file included from net/bridge/br_netlink_tunnel.c:18: >> net/bridge/br_private.h:94:32: warning: 'struct net_bridge_port' declared inside parameter list will not be visible outside of this definition or declaration 94 | int (*frame_handler)(struct net_bridge_port *port, | ^~~~~~~~~~~~~~~ net/bridge/br_netlink_tunnel.c:29:6: warning: no previous prototype for 'vlan_tunid_inrange' [-Wmissing-prototypes] 29 | bool vlan_tunid_inrange(const struct net_bridge_vlan *v_curr, | ^~~~~~~~~~~~~~~~~~ net/bridge/br_netlink_tunnel.c:196:5: warning: no previous prototype for 'br_vlan_tunnel_info' [-Wmissing-prototypes] 196 | int br_vlan_tunnel_info(const struct net_bridge_port *p, int cmd, | ^~~~~~~~~~~~~~~~~~~ -- In file included from net/atm/lec.c:36: >> net/atm/../bridge/br_private.h:94:32: warning: 'struct net_bridge_port' declared inside parameter list will not be visible outside of this definition or declaration 94 | int (*frame_handler)(struct net_bridge_port *port, | ^~~~~~~~~~~~~~~ vim +13 net/bridge/br_mrp.c 10 11 static struct br_frame_type mrp_frame_type __read_mostly = { 12 .type = cpu_to_be16(ETH_P_MRP), > 13 .frame_handler = br_mrp_process, 14 }; 15 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org