From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org (open list),
vladimir.oltean@nxp.com, olteanv@gmail.com
Subject: [PATCH net-next 0/4] net: dsa: Improve dsa_untag_bridge_pvid()
Date: Thu, 1 Oct 2020 19:42:11 -0700 [thread overview]
Message-ID: <20201002024215.660240-1-f.fainelli@gmail.com> (raw)
Hi David, Jakub,
This patch series is based on the recent discussions with Vladimir:
https://lore.kernel.org/netdev/20201001030623.343535-1-f.fainelli@gmail.com/
the simplest way forward was to call dsa_untag_bridge_pvid() after
eth_type_trans() has been set which guarantees that skb->protocol is set
to a correct value and this allows us to utilize
__vlan_find_dev_deep_rcu() properly without playing or using the bridge
master as a net_device reference.
Florian Fainelli (4):
net: dsa: Call dsa_untag_bridge_pvid() from dsa_switch_rcv()
net: dsa: b53: Set untag_bridge_pvid
net: dsa: Obtain VLAN protocol from skb->protocol
net: dsa: Utilize __vlan_find_dev_deep_rcu()
drivers/net/dsa/b53/b53_common.c | 1 +
include/net/dsa.h | 8 ++++++++
net/dsa/dsa.c | 9 +++++++++
net/dsa/dsa_priv.h | 14 ++++----------
net/dsa/tag_brcm.c | 15 ++-------------
5 files changed, 24 insertions(+), 23 deletions(-)
--
2.25.1
next reply other threads:[~2020-10-02 2:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 2:42 Florian Fainelli [this message]
2020-10-02 2:42 ` [PATCH net-next 1/4] net: dsa: Call dsa_untag_bridge_pvid() from dsa_switch_rcv() Florian Fainelli
2020-10-02 8:39 ` Vladimir Oltean
2020-10-02 2:42 ` [PATCH net-next 2/4] net: dsa: b53: Set untag_bridge_pvid Florian Fainelli
2020-10-02 8:40 ` Vladimir Oltean
2020-10-02 2:42 ` [PATCH net-next 3/4] net: dsa: Obtain VLAN protocol from skb->protocol Florian Fainelli
2020-10-02 8:41 ` Vladimir Oltean
2020-10-02 2:42 ` [PATCH net-next 4/4] net: dsa: Utilize __vlan_find_dev_deep_rcu() Florian Fainelli
2020-10-02 8:42 ` Vladimir Oltean
2020-10-02 20:36 ` [PATCH net-next 0/4] net: dsa: Improve dsa_untag_bridge_pvid() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002024215.660240-1-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).