From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3F19C4363D for ; Fri, 2 Oct 2020 07:15:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FB5C206DD for ; Fri, 2 Oct 2020 07:15:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726096AbgJBHP0 (ORCPT ); Fri, 2 Oct 2020 03:15:26 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:38911 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbgJBHP0 (ORCPT ); Fri, 2 Oct 2020 03:15:26 -0400 X-Originating-IP: 91.224.148.103 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id EFA5B1BF217; Fri, 2 Oct 2020 07:15:20 +0000 (UTC) From: Miquel Raynal To: Florian Fainelli , linux-mtd@lists.infradead.org Cc: Miquel Raynal , Vignesh Raghavendra , Richard Weinberger , open list , =?utf-8?q?=C3=81lvaro_Fern=C3=A1n?= =?utf-8?q?dez_Rojas?= , Jonas Gorski Subject: Re: [PATCH] mtd: parsers: bcm63xx: Do not make it modular Date: Fri, 2 Oct 2020 09:15:19 +0200 Message-Id: <20201002071519.26282-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200929172726.30469-1-f.fainelli@gmail.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b597cc75f7fe76708bc6ab3f0e09bbff6f09ae4a Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-09-29 at 17:27:21 UTC, Florian Fainelli wrote: > With commit 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE > detection"), we generate a reference to fw_arg3 which is the fourth > firmware/command line argument on MIPS platforms. That symbol is not > exported and would cause a linking failure. > > The parser is typically necessary to boot a BCM63xx-based system anyway > so having it be part of the kernel image makes sense, therefore make it > 'bool' instead of 'tristate'. > > Fixes: 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE detection") > Signed-off-by: Florian Fainelli Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel