From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A44C4363D for ; Fri, 2 Oct 2020 08:20:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D65C620719 for ; Fri, 2 Oct 2020 08:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601626826; bh=uEDTrzujBpH5DEQPH2Cu3XQnqC1RNVCSomyfZCH8l9I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KYs6WLmZLTIO5LTzYUqGQWBFXxekh5nrDCo8lp/zGQzzANudFzfBwpXQE4vOZPb43 btyyBADsb0qYo8jYHvxvec9liJNxIdFfyxqZnoEt/1OZRyJlLvxX7HBkd/ACvwdSBu +LVXP5niOY0uv5EbEjm2lKOb8alpfatc3zPM7ZPk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387638AbgJBIUZ (ORCPT ); Fri, 2 Oct 2020 04:20:25 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:35838 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387536AbgJBIUS (ORCPT ); Fri, 2 Oct 2020 04:20:18 -0400 Received: by mail-ed1-f65.google.com with SMTP id i1so791924edv.2; Fri, 02 Oct 2020 01:20:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Bkh1SP/RxLZt/FHcHaOcXfHwmKZUTF99Sb6EVCBToAI=; b=CS85g0ZND0gmO0VZCaW0s9IxXZ/PZJ4mYMYi1U/mC2B81cYYKzk69+oT9Xk2Mlb2kY cACf9gK+TiTob/GHClgDBpTU1nwRr0H7KznKlUmSf39n98k30qAttHLtOQXOwym8N50T XPlsmiHBRvr39z3veAOGkYg82aY3ThTWBWDZ7qgBkWCfCuhfvzBnd+s2hxjsXxzfqfUU CkkJfbd4UrHBGV8OyuSCyCeJruyO0SN0miv3ETvReDq91B1Yc568imt8eZHCQLOXY7qg 4TZNffrRoCg9D1KnpMW7QVphmf7lIWVw4KLd84OaqEqdmeAAxe7GYEXTgZIDvqEYjszG ROQA== X-Gm-Message-State: AOAM531zYF5YKGoz2xHRRb2czxRLfP9MIOpyTuydzmk/3J22mDBINsid QZrBrIA1DAytCZKfpUEye6Q= X-Google-Smtp-Source: ABdhPJxX55AwyVhonHu2pITZEj1/D9GVJtA481IouPj2agmtzYOF7zuZPrsa4fVc+noKKiqP5rLSgA== X-Received: by 2002:aa7:d1d5:: with SMTP id g21mr1145493edp.348.1601626815502; Fri, 02 Oct 2020 01:20:15 -0700 (PDT) Received: from pi3 ([194.230.155.194]) by smtp.googlemail.com with ESMTPSA id y25sm633136edv.15.2020.10.02.01.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 01:20:14 -0700 (PDT) Date: Fri, 2 Oct 2020 10:20:12 +0200 From: Krzysztof Kozlowski To: Ahmad Fatoum Cc: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Anson Huang , Andreas Kemnade , Stefan Riedmueller , Robert Jones , Li Yang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles Message-ID: <20201002082012.GA6605@pi3> References: <20200930190143.27032-1-krzk@kernel.org> <20200930190143.27032-9-krzk@kernel.org> <0a0afea6-8cbb-3e89-5a4f-89660c942ca3@pengutronix.de> <20201001073208.GA5208@kozik-lap> <027fd826-6822-9e92-0c6c-2ebed63f4a07@pengutronix.de> <20201001103704.GA26287@kozik-lap> <7fcea21d-4651-9ba7-5331-86530296a847@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7fcea21d-4651-9ba7-5331-86530296a847@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 02, 2020 at 09:41:28AM +0200, Ahmad Fatoum wrote: > Hello, > > On 10/1/20 12:37 PM, Krzysztof Kozlowski wrote: > >> The existing binding doesn't cover these boards then and needs to be > >> extended, no? How about following patch? > > > > What do you mean it doesn't cover? It was added exactly to handle them: > > + - technexion,imx6q-pico-dwarf # TechNexion i.MX6Q Pico-Dwarf > > + - technexion,imx6q-pico-hobbit # TechNexion i.MX6Q Pico-Hobbit > > + - technexion,imx6q-pico-nymph # TechNexion i.MX6Q Pico-Nymph > > + - technexion,imx6q-pico-pi # TechNexion i.MX6Q Pico-Pi > > > > Still they are unused. So I'd think these boards should be handled like boards > that predated bindings: a binding is written that doesn't break existing users. OK, let's assume the binding is not correct and DTSes are good. > > >> [I guess we need to keep the two-compatible list they were originally > >> in for compatibility even if it's unused among upstream device trees?] > > > > You want to change both the binding (thus breaking the ABI) and update > > the DTS to reflect new ABI. Then why having a binding at all? > > If we leave the old two-compatible enumeration intact, there is no ABI broken. Just to clarify, because I don't get here the "no ABI broken" part: ABI is the binding, not the DTS. We can change intree DTS as we like, replace compatibles, add nodes, remove nodes. There is no stability requirement for DTS contents. If we leave two-compatible binding intact, it is a broken binding since beginning. Removing non-working, fake ABI is not breaking it because it could never work. > > > I would assume that either binding is correct or DTS. You propose that > > both are wrong and both need changes... in such case this is clearly > > broken. > > IMO the DTS is the correct one. If you want to honor the author's intention > that each base board has a different compatible, it should be an extra > compatible and not replace the existing one that may be already in use. OK, we can go with DTS approach. I fixed few of such cases as well, assuming that DTS was intended and binding was incorrect. In such case all boards will be documented under one compatible technexion,imx6q-pico and DTS will not be changed. Best regards, Krzysztof