From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC] Status of orinoco_usb
Date: Fri, 2 Oct 2020 14:06:25 +0200 [thread overview]
Message-ID: <20201002120625.GA3341753@kroah.com> (raw)
In-Reply-To: <20201002115358.6aqemcn5vqc5yqtw@linutronix.de>
On Fri, Oct 02, 2020 at 01:53:58PM +0200, Sebastian Andrzej Siewior wrote:
> On 2020-10-02 13:37:25 [+0200], Greg Kroah-Hartman wrote:
> > > Is it possible to end up here in softirq context or is this a relic?
> >
> > I think it's a relic of where USB host controllers completed their urbs
> > in hard-irq mode. The BH/tasklet change is a pretty recent change.
>
> But the BH thingy for HCDs went in v3.12 for EHCI. XHCI was v5.5. My
> guess would be that people using orinoco USB are on EHCI :)
USB 3 systems run XHCI, which has a USB 2 controller in it, so these
types of things might not have been noticed yet. Who knows :)
> > > Should it be removed?
> >
> > We can move it out to drivers/staging/ and then drop it to see if anyone
> > complains that they have the device and is willing to test any changes.
>
> Not sure moving is easy since it depends on other files in that folder.
> USB is one interface next to PCI for instance. Unless you meant to move
> the whole driver including all interfaces.
> I was suggesting to remove the USB bits.
I forgot this was tied into other code, sorry. I don't know what to
suggest other than maybe try to fix it up the best that you can, and
let's see if anyone notices...
thanks,
greg k-h
next prev parent reply other threads:[~2020-10-02 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 10:35 [RFC] Status of orinoco_usb Sebastian Andrzej Siewior
2020-10-02 11:37 ` Greg Kroah-Hartman
2020-10-02 11:53 ` Sebastian Andrzej Siewior
2020-10-02 12:06 ` Greg Kroah-Hartman [this message]
2020-10-05 14:12 ` Kalle Valo
2020-10-06 7:45 ` Arend Van Spriel
2020-10-06 12:40 ` Jes Sorensen
2020-10-06 15:05 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002120625.GA3341753@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).