From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 602A5C4363D for ; Fri, 2 Oct 2020 19:13:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DA1620758 for ; Fri, 2 Oct 2020 19:13:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="ytUa4lMM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388360AbgJBTNV (ORCPT ); Fri, 2 Oct 2020 15:13:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725991AbgJBTNV (ORCPT ); Fri, 2 Oct 2020 15:13:21 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12BC8C0613D0 for ; Fri, 2 Oct 2020 12:13:21 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id y14so1401994pgf.12 for ; Fri, 02 Oct 2020 12:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4E58JDWcyE9kHD+mQNg34Irk/7DDzMGRzQkdVU3JrAQ=; b=ytUa4lMM03Lk/3vOWIwHDchVWLwTbBS+psnP0aqtOMfQplZiPbsxZ5IhvpU+NxGJnF 5X9XhhBWk2sTfhepgaiaT+ytA9xSjw7Yrv2BxGmowDMg6d13i3FAOB8p+moegDR0zY8f mqVSFGj/EpLPAGGhK4IJKG2ttesIGD6Qk9HoeHsVSvZajh68j6m3PN1lp7ciKZPZDytO 9tklsc556dwDJC23qspyKwy2jEUv4K4STEcvrhcm4XgZd/Nmau6cQje120RRfJljl7v8 g/uvoRhBmgWVa+HKxHzCYhX7vsBRC3ujPOI0EtuwQyMNbzkrcBb5vM6CB9N8lWOEXo3U 1NBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4E58JDWcyE9kHD+mQNg34Irk/7DDzMGRzQkdVU3JrAQ=; b=dkocg8WbfJiGRuz+lg4Jyf/qWk9RgBN2D7k2WgP5eSuETXV9PJo+17zjix8KZ3KfBo mH3wsW7Y9SWjRmEgySkfl+2g/jf0HAIFoutUpt4n7sxyE5NnVXii9WXDrtk+FfKr8ZGr cH9vLQ1dWnZRm2HNoOPHnguue7JR6UhwLAe9H7QcopsiXx4/bOve5enV1dDLf6r113Tc WF5cpIO5MMq4oHFlgMRmz/7+J4yry3BkERkm7nhUpaX7gaMS9ukscOclXkOvuUGhyopT F1oU3ZPH6oITw8prtXpGPVn0pE/03Bs+EtsbmG/khwFNMSYtCsZhflNsuxv8oR0VZ4dg /RjQ== X-Gm-Message-State: AOAM531IAfDrmib2z5ELv6u4Fc0Ek/jnM3u5W6JX/TUXXawjXgNeK4xk RhzMyOAnUZvzKcoMQ9d3B0myfA== X-Google-Smtp-Source: ABdhPJwWjUANm1SSr9bTPMgtcY0BxAcpSbDKXj+7xVHyDV4BV7WPuTsieg/+DQkLC7h7cBiNpYKF8w== X-Received: by 2002:a63:456:: with SMTP id 83mr3776594pge.210.1601666000662; Fri, 02 Oct 2020 12:13:20 -0700 (PDT) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id t186sm2372583pgc.49.2020.10.02.12.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 12:13:20 -0700 (PDT) Date: Fri, 2 Oct 2020 12:13:17 -0700 From: Stephen Hemminger To: Jarod Wilson Cc: linux-kernel@vger.kernel.org, Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S. Miller" , Jakub Kicinski , Thomas Davis , netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces Message-ID: <20201002121317.474c95f0@hermes.local> In-Reply-To: <20201002174001.3012643-7-jarod@redhat.com> References: <20201002174001.3012643-1-jarod@redhat.com> <20201002174001.3012643-7-jarod@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2 Oct 2020 13:40:01 -0400 Jarod Wilson wrote: > By default, enable retaining all user-facing API that includes the use of > master and slave, but add a Kconfig knob that allows those that wish to > remove it entirely do so in one shot. > > Cc: Jay Vosburgh > Cc: Veaceslav Falico > Cc: Andy Gospodarek > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Thomas Davis > Cc: netdev@vger.kernel.org > Signed-off-by: Jarod Wilson > --- > drivers/net/Kconfig | 12 ++++++++++++ > drivers/net/bonding/bond_main.c | 4 ++-- > drivers/net/bonding/bond_options.c | 4 ++-- > drivers/net/bonding/bond_procfs.c | 8 ++++++++ > drivers/net/bonding/bond_sysfs.c | 14 ++++++++++---- > drivers/net/bonding/bond_sysfs_port.c | 6 ++++-- > 6 files changed, 38 insertions(+), 10 deletions(-) > This is problematic. You are printing both old and new values. Also every distribution will have to enable it. This looks like too much of change to users.