linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][V2] selftests/ftrace: check for do_sys_openat2 in user-memory test
@ 2020-10-02 13:25 Colin King
  2020-10-05 14:42 ` Masami Hiramatsu
  2020-10-08 20:48 ` Steven Rostedt
  0 siblings, 2 replies; 4+ messages in thread
From: Colin King @ 2020-10-02 13:25 UTC (permalink / raw)
  To: Steven Rostedt, Ingo Molnar, Shuah Khan, Tom Zanussi,
	Masami Hiramatsu, linux-kselftest
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

More recent libc implementations are now using openat/openat2 system
calls so also add do_sys_openat2 to the tracing so that the test
passes on these systems because do_sys_open may not be called.

Thanks to Masami Hiramatsu for the help on getting this fix to work
correctly.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---

V2: write myevent2 using >> rather than >, also enable and disable
    myevent2
---
 .../selftests/ftrace/test.d/kprobe/kprobe_args_user.tc        | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc
index a30a9c07290d..d25d01a19778 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc
@@ -9,12 +9,16 @@ grep -A10 "fetcharg:" README | grep -q '\[u\]<offset>' || exit_unsupported
 :;: "user-memory access syntax and ustring working on user memory";:
 echo 'p:myevent do_sys_open path=+0($arg2):ustring path2=+u0($arg2):string' \
 	> kprobe_events
+echo 'p:myevent2 do_sys_openat2 path=+0($arg2):ustring path2=+u0($arg2):string' \
+	>> kprobe_events
 
 grep myevent kprobe_events | \
 	grep -q 'path=+0($arg2):ustring path2=+u0($arg2):string'
 echo 1 > events/kprobes/myevent/enable
+echo 1 > events/kprobes/myevent2/enable
 echo > /dev/null
 echo 0 > events/kprobes/myevent/enable
+echo 0 > events/kprobes/myevent2/enable
 
 grep myevent trace | grep -q 'path="/dev/null" path2="/dev/null"'
 
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH][V2] selftests/ftrace: check for do_sys_openat2 in user-memory test
  2020-10-02 13:25 [PATCH][V2] selftests/ftrace: check for do_sys_openat2 in user-memory test Colin King
@ 2020-10-05 14:42 ` Masami Hiramatsu
  2020-10-08 20:48 ` Steven Rostedt
  1 sibling, 0 replies; 4+ messages in thread
From: Masami Hiramatsu @ 2020-10-05 14:42 UTC (permalink / raw)
  To: Colin King
  Cc: Steven Rostedt, Ingo Molnar, Shuah Khan, Tom Zanussi,
	linux-kselftest, kernel-janitors, linux-kernel

Hi,

On Fri,  2 Oct 2020 14:25:01 +0100
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> More recent libc implementations are now using openat/openat2 system
> calls so also add do_sys_openat2 to the tracing so that the test
> passes on these systems because do_sys_open may not be called.
> 
> Thanks to Masami Hiramatsu for the help on getting this fix to work
> correctly.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

OK, this looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you!

> ---
> 
> V2: write myevent2 using >> rather than >, also enable and disable
>     myevent2
> ---
>  .../selftests/ftrace/test.d/kprobe/kprobe_args_user.tc        | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc
> index a30a9c07290d..d25d01a19778 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc
> @@ -9,12 +9,16 @@ grep -A10 "fetcharg:" README | grep -q '\[u\]<offset>' || exit_unsupported
>  :;: "user-memory access syntax and ustring working on user memory";:
>  echo 'p:myevent do_sys_open path=+0($arg2):ustring path2=+u0($arg2):string' \
>  	> kprobe_events
> +echo 'p:myevent2 do_sys_openat2 path=+0($arg2):ustring path2=+u0($arg2):string' \
> +	>> kprobe_events
>  
>  grep myevent kprobe_events | \
>  	grep -q 'path=+0($arg2):ustring path2=+u0($arg2):string'
>  echo 1 > events/kprobes/myevent/enable
> +echo 1 > events/kprobes/myevent2/enable
>  echo > /dev/null
>  echo 0 > events/kprobes/myevent/enable
> +echo 0 > events/kprobes/myevent2/enable
>  
>  grep myevent trace | grep -q 'path="/dev/null" path2="/dev/null"'
>  
> -- 
> 2.27.0
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][V2] selftests/ftrace: check for do_sys_openat2 in user-memory test
  2020-10-02 13:25 [PATCH][V2] selftests/ftrace: check for do_sys_openat2 in user-memory test Colin King
  2020-10-05 14:42 ` Masami Hiramatsu
@ 2020-10-08 20:48 ` Steven Rostedt
  2020-10-27 19:22   ` Shuah Khan
  1 sibling, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2020-10-08 20:48 UTC (permalink / raw)
  To: Colin King, Shuah Khan
  Cc: Ingo Molnar, Tom Zanussi, Masami Hiramatsu, linux-kselftest,
	kernel-janitors, linux-kernel, Shuah Khan

On Fri,  2 Oct 2020 14:25:01 +0100
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> More recent libc implementations are now using openat/openat2 system
> calls so also add do_sys_openat2 to the tracing so that the test
> passes on these systems because do_sys_open may not be called.
> 
> Thanks to Masami Hiramatsu for the help on getting this fix to work
> correctly.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Shuah,

Care to take this through your tree?

-- Steve

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][V2] selftests/ftrace: check for do_sys_openat2 in user-memory test
  2020-10-08 20:48 ` Steven Rostedt
@ 2020-10-27 19:22   ` Shuah Khan
  0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2020-10-27 19:22 UTC (permalink / raw)
  To: Steven Rostedt, Colin King, Shuah Khan
  Cc: Ingo Molnar, Tom Zanussi, Masami Hiramatsu, linux-kselftest,
	kernel-janitors, linux-kernel, Shuah Khan

On 10/8/20 2:48 PM, Steven Rostedt wrote:
> On Fri,  2 Oct 2020 14:25:01 +0100
> Colin King <colin.king@canonical.com> wrote:
> 
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> More recent libc implementations are now using openat/openat2 system
>> calls so also add do_sys_openat2 to the tracing so that the test
>> passes on these systems because do_sys_open may not be called.
>>
>> Thanks to Masami Hiramatsu for the help on getting this fix to work
>> correctly.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 
> Shuah,
> 
> Care to take this through your tree?
> 

Yes - Will include in my next fixes pull request.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-10-27 19:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02 13:25 [PATCH][V2] selftests/ftrace: check for do_sys_openat2 in user-memory test Colin King
2020-10-05 14:42 ` Masami Hiramatsu
2020-10-08 20:48 ` Steven Rostedt
2020-10-27 19:22   ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).