From: Andrew Morton <akpm@linux-foundation.org>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Shuah Khan <shuah@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-kselftest@vger.kernel.org>,
Sri Jayaramappa <sjayaram@akamai.com>
Subject: Re: [PATCH 1/1] selftests/vm: 8x compaction_test speedup
Date: Fri, 2 Oct 2020 15:05:20 -0700 [thread overview]
Message-ID: <20201002150520.2ea3db53d88f8d10ba8348c9@linux-foundation.org> (raw)
In-Reply-To: <20201002080621.551044-2-jhubbard@nvidia.com>
On Fri, 2 Oct 2020 01:06:21 -0700 John Hubbard <jhubbard@nvidia.com> wrote:
> This patch reduces the running time for compaction_test from about 27
> sec, to 3.3 sec, which is about an 8x speedup.
>
> These numbers are for an Intel x86_64 system with 32 GB of DRAM.
>
> The compaction_test.c program was spending most of its time doing
> mmap(), 1 MB at a time, on about 25 GB of memory.
>
> Instead, do the mmaps 100 MB at a time. (Going past 100 MB doesn't make
> things go much faster, because other parts of the program are using the
> remaining time.)
Seems nice. It's been 5 years, but hopefully Sri is still at Akamai?
> --- a/tools/testing/selftests/vm/compaction_test.c
> +++ b/tools/testing/selftests/vm/compaction_test.c
> @@ -18,7 +18,8 @@
>
> #include "../kselftest.h"
>
> -#define MAP_SIZE 1048576
> +#define MAP_SIZE_MB 100
> +#define MAP_SIZE (MAP_SIZE_MB * 1024 * 1024)
>
> struct map_list {
> void *map;
> @@ -165,7 +166,7 @@ int main(int argc, char **argv)
> void *map = NULL;
> unsigned long mem_free = 0;
> unsigned long hugepage_size = 0;
> - unsigned long mem_fragmentable = 0;
> + long mem_fragmentable_MB = 0;
>
> if (prereq() != 0) {
> printf("Either the sysctl compact_unevictable_allowed is not\n"
> @@ -190,9 +191,9 @@ int main(int argc, char **argv)
> return -1;
> }
>
> - mem_fragmentable = mem_free * 0.8 / 1024;
> + mem_fragmentable_MB = mem_free * 0.8 / 1024;
>
> - while (mem_fragmentable > 0) {
> + while (mem_fragmentable_MB > 0) {
> map = mmap(NULL, MAP_SIZE, PROT_READ | PROT_WRITE,
> MAP_ANONYMOUS | MAP_PRIVATE | MAP_LOCKED, -1, 0);
> if (map == MAP_FAILED)
> @@ -213,7 +214,7 @@ int main(int argc, char **argv)
> for (i = 0; i < MAP_SIZE; i += page_size)
> *(unsigned long *)(map + i) = (unsigned long)map + i;
>
> - mem_fragmentable--;
> + mem_fragmentable_MB -= MAP_SIZE_MB;
> }
>
> for (entry = list; entry != NULL; entry = entry->next) {
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-10-02 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 8:06 [PATCH 0/1] selftests/vm: 8x compaction_test speedup John Hubbard
2020-10-02 8:06 ` [PATCH 1/1] " John Hubbard
2020-10-02 22:05 ` Andrew Morton [this message]
2020-10-02 23:25 ` Jayaramappa, Srilakshmi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002150520.2ea3db53d88f8d10ba8348c9@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=sjayaram@akamai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).