From: Peter Xu <peterx@redhat.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A . Shutemov" <kirill@shutemov.name>
Subject: Re: [PATCH] mm: Remove src/dst mm parameter in copy_page_range()
Date: Fri, 2 Oct 2020 14:04:14 -0400 [thread overview]
Message-ID: <20201002180414.GD5473@xz-x1> (raw)
In-Reply-To: <20201002172858.GK9916@ziepe.ca>
On Fri, Oct 02, 2020 at 02:28:58PM -0300, Jason Gunthorpe wrote:
> On Fri, Oct 02, 2020 at 01:14:29PM -0400, Peter Xu wrote:
> > On Fri, Oct 02, 2020 at 08:43:12AM -0300, Jason Gunthorpe wrote:
> > > > -static int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *src_mm,
> > > > - pmd_t *dst_pmd, pmd_t *src_pmd, struct vm_area_struct *vma,
> > > > - struct vm_area_struct *new,
> > > > +static int copy_pte_range(pmd_t *dst_pmd, pmd_t *src_pmd,
> > > > + struct vm_area_struct *vma, struct vm_area_struct *new,
> > > > unsigned long addr, unsigned long end)
> > >
> > > I link this, my only minor quibble is the mixing of dst/src and new
> > > language, and then reversing the order in each place. Would read
> > > better to be consistent:
> > >
> > > copy_pte_range(dst_vma, dst_pmd, src_vma, src_pmd, addr, end)
> >
> > I have no strong opinion on the ordering, but I agree the names are clearer.
> > Considering normally we put the same type of parameters to be together, how
> > about:
> >
> > copy_pte_range(dst_vma, src_vma, dst_pmd, src_pmd, addr, end)
>
> I was looking at the order of (dst_pmd, src_pmd, src_vma, dest_vma)
>
> Whichever, just have some logic to it :)
Oh, sure. :)
--
Peter Xu
prev parent reply other threads:[~2020-10-02 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 20:49 [PATCH] mm: Remove src/dst mm parameter in copy_page_range() Peter Xu
2020-10-02 11:43 ` Jason Gunthorpe
2020-10-02 17:14 ` Peter Xu
2020-10-02 17:28 ` Jason Gunthorpe
2020-10-02 18:04 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002180414.GD5473@xz-x1 \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jgg@ziepe.ca \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).