From: Jason Gunthorpe <jgg@ziepe.ca>
To: Peter Xu <peterx@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] mm: Remove src/dst mm parameter in copy_page_range()
Date: Fri, 2 Oct 2020 20:32:57 -0300 [thread overview]
Message-ID: <20201002233257.GN9916@ziepe.ca> (raw)
In-Reply-To: <20201002192647.7161-1-peterx@redhat.com>
On Fri, Oct 02, 2020 at 03:26:47PM -0400, Peter Xu wrote:
> Both of the mm pointers are not needed after commit 7a4830c380f3 ("mm/fork:
> Pass new vma pointer into copy_page_range()").
>
> Jason Gunthorpe also reported that the ordering of copy_page_range() is odd.
> Since working at it, reorder the parameters to be logical, by (1) always put
> the dst_* fields to be before src_* fields, and (2) keep the same type of
> parameters together.
>
> CC: Jason Gunthorpe <jgg@ziepe.ca>
> CC: Andrew Morton <akpm@linux-foundation.org>
> Reported-by: Kirill A. Shutemov <kirill@shutemov.name>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> v2:
> - further reorder some parameters and line format [Jason]
> ---
> include/linux/mm.h | 4 +-
> kernel/fork.c | 2 +-
> mm/memory.c | 139 ++++++++++++++++++++++++---------------------
> 3 files changed, 76 insertions(+), 69 deletions(-)
Thanks, looks more readable to me
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2020-10-02 23:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 19:26 [PATCH v2] mm: Remove src/dst mm parameter in copy_page_range() Peter Xu
2020-10-02 23:32 ` Jason Gunthorpe [this message]
2020-10-05 12:07 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002233257.GN9916@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).