From: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card
Date: Sun, 4 Oct 2020 20:30:42 +0200 [thread overview]
Message-ID: <20201004203042.093ac473@monster.powergraphx.local> (raw)
In-Reply-To: <87d01yovq5.fsf@miraculix.mork.no>
On Sun, 04 Oct 2020 17:29:38 +0200
Bjørn Mork <bjorn@mork.no> wrote:
> Wilken Gottwalt <wilken.gottwalt@mailbox.org> writes:
>
> > Add usb ids of the Cellient MPL200 card.
> >
> > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> > ---
> > drivers/net/usb/qmi_wwan.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> > index 07c42c0719f5..0bf2b19d5d54 100644
> > --- a/drivers/net/usb/qmi_wwan.c
> > +++ b/drivers/net/usb/qmi_wwan.c
>
> This is not a 'usb: serial' driver. Please resend with a less confusing
> subject prefix.
>
> > @@ -1432,6 +1432,7 @@ static const struct usb_device_id products[] = {
> > {QMI_GOBI_DEVICE(0x1199, 0x901b)}, /* Sierra Wireless MC7770 */
> > {QMI_GOBI_DEVICE(0x12d1, 0x14f1)}, /* Sony Gobi 3000 Composite */
> > {QMI_GOBI_DEVICE(0x1410, 0xa021)}, /* Foxconn Gobi 3000 Modem device (Novatel
> > E396) */
> > + {QMI_FIXED_INTF(0x2692, 0x9025, 4)}, /* Cellient MPL200 (rebranded Qualcomm
> > 0x05c6) */
> > { } /* END */
> > };
>
>
> This table is supposed to be organized by device type. The last section
> is for Gobi2k and Gobi3k devices. Please try to put new devices into
> the correct section.
Oh sorry, looks like I got it mixed up a bit. It was my first attempt to submit
a patch set. Which is the best way to resubmit an update if the other part of
the patch set gets accepted? The documentation about re-/submitting patch sets
is a bit thin.
Will
next prev parent reply other threads:[~2020-10-04 18:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 9:39 [PATCH 0/2] add Cellient MPL200 card Wilken Gottwalt
2020-10-03 9:39 ` [PATCH 1/2] usb: serial: qmi_wwan: " Wilken Gottwalt
2020-10-04 15:29 ` Bjørn Mork
2020-10-04 18:30 ` Wilken Gottwalt [this message]
2020-10-05 8:06 ` Johan Hovold
2020-10-05 8:19 ` Johan Hovold
2020-10-05 10:07 ` Bjørn Mork
2020-10-03 9:40 ` [PATCH 2/2] usb: serial: option: " Wilken Gottwalt
2020-10-05 8:20 ` Johan Hovold
2020-10-05 11:01 ` Wilken Gottwalt
2020-10-05 11:06 ` Johan Hovold
2020-10-05 11:36 ` Lars Melin
2020-10-05 12:07 ` Wilken Gottwalt
2020-10-06 7:02 ` Johan Hovold
2020-10-08 6:47 ` Wilken Gottwalt
2020-10-08 7:16 ` Johan Hovold
2020-10-05 12:02 ` Wilken Gottwalt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201004203042.093ac473@monster.powergraphx.local \
--to=wilken.gottwalt@mailbox.org \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).