From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E611C35257 for ; Mon, 5 Oct 2020 03:41:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5DFD207FB for ; Mon, 5 Oct 2020 03:41:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601869309; bh=vgyk5ypX915tVD4vhCLypoGHnjjpPzUVAZJByu6lzog=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=OQ8aqA2Q+2xH4mN8cRT2QE4RiB2tuLD/e1KFkNLsUbT67Gh9yl/YgCWk6C/zP0yzv i5pPrbIrYKmHwOJflsxOBOjJs6fWpbnZQL9Mt0XXw7dqLCHMTPTB6E9Q/sMrY7wrNS amLzxtwAY4032nefk24MwipZNASVbuyQ60I1/H2c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725864AbgJEDls (ORCPT ); Sun, 4 Oct 2020 23:41:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:49648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725845AbgJEDls (ORCPT ); Sun, 4 Oct 2020 23:41:48 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A6F92207F7; Mon, 5 Oct 2020 03:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601869308; bh=vgyk5ypX915tVD4vhCLypoGHnjjpPzUVAZJByu6lzog=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vG4Xni21hbDZBADEV2O44raKRMyUZ/+zn/tbA5aZeZ6Mu+qCjxIlWWR953RPOKD1D PNPg+h4V7wyTCT54LDj60KW6X6bKqCZjv3cv0AX6ZMY9XabTxtbUQ2Cx0LIncByKDN bmKrcAYJ/V1nbYwCpTV736nPdoraSGtvdj3uylqM= Date: Mon, 5 Oct 2020 12:41:41 +0900 From: Masami Hiramatsu To: Josh Poimboeuf Cc: Vasily Gorbik , Peter Zijlstra , Thomas Gleixner , Masami Hiramatsu , David Laight , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Miroslav Benes , Alexandre Chartre , Julien Thierry , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v3 2/4] objtool: x86 instruction decoder and big endian cross compiles Message-Id: <20201005124141.6a523ef633248a1eefd724d3@kernel.org> In-Reply-To: <20201002151841.4ojt45mtcpkylvdq@treble> References: <20201002151841.4ojt45mtcpkylvdq@treble> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2 Oct 2020 10:18:41 -0500 Josh Poimboeuf wrote: > On Thu, Oct 01, 2020 at 12:17:25AM +0200, Vasily Gorbik wrote: > > From: Martin Schwidefsky > > > > Currently objtool seems to be the only tool from build tools needed > > which breaks x86 cross compilation on big endian systems. Make the x86 > > instruction decoder of the objtool usable on big endian machines. > > > > Signed-off-by: Martin Schwidefsky > > Co-developed-by: Vasily Gorbik > > Signed-off-by: Vasily Gorbik > > Since this changes the decoder (which is shared with the kernel), please > prefix the subject with "x86/insn:" instead of "objtool". Thanks for pointing it. > > This patch is a bit ugly, but I don't necessarily have a better idea. > > Masami? Yeah, agreed. Maybe we can split that part in different header, but that makes it more ugly. And code itself looks good to me. (I like insn_field_set() idea :) ) Acked-by: Masami Hiramatsu Thank you! > -- > Josh > -- Masami Hiramatsu