From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87F5AC4727D for ; Mon, 5 Oct 2020 15:33:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40C7B20B80 for ; Mon, 5 Oct 2020 15:33:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601912022; bh=Wy8BrbxzVvsYcDgfrHGkLAbAEoHExqxYGnoze5KbJJk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=EP3CyRE8MSa9fbATAvk2ee7QiTgh65bBG4cyKkjOosEwOh54tZ0XjMJSz0HlcphfW ORAmUf0QoNmu7VgSX/G5cDaNNjYdkBURlYbAFJT1xLibtGNTA0fPov4GJAEKwiFFVA +rxol3MrZQm0RSEFKNtWkhKpgtw4107+uGaHqd0c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728180AbgJEPdl (ORCPT ); Mon, 5 Oct 2020 11:33:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:33502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728153AbgJEPd3 (ORCPT ); Mon, 5 Oct 2020 11:33:29 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 341342074F; Mon, 5 Oct 2020 15:33:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601912008; bh=Wy8BrbxzVvsYcDgfrHGkLAbAEoHExqxYGnoze5KbJJk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hM+zH+6TNJQnbfsGwhg4+hm21SjHZeYyKDs8zSkzEwiUsxXeA0pnz3zgG5qNL672P doTRr+9C/MQ4FKZab2X2c5ckQGV4veQveY2hwbuLZ+KvwmsjMoaWXj8PTNDlM0SV7j qfNzdDutk+vFVVnBOKS8DZSw8K1wQHAHMq/zFNMs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tao Ren , Andrew Jeffery , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 5.8 65/85] gpio: aspeed: fix ast2600 bank properties Date: Mon, 5 Oct 2020 17:27:01 +0200 Message-Id: <20201005142117.854225586@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201005142114.732094228@linuxfoundation.org> References: <20201005142114.732094228@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tao Ren [ Upstream commit 3e640b1eec38e4c8eba160f26cba4f592e657f3d ] GPIO_U is mapped to the least significant byte of input/output mask, and the byte in "output" mask should be 0 because GPIO_U is input only. All the other bits need to be 1 because GPIO_V/W/X support both input and output modes. Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the according bits need to be 1 because GPIO_Y/Z support both input and output modes. Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver") Signed-off-by: Tao Ren Reviewed-by: Andrew Jeffery Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-aspeed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index 879db23d84549..d07bf2c3f1369 100644 --- a/drivers/gpio/gpio-aspeed.c +++ b/drivers/gpio/gpio-aspeed.c @@ -1114,8 +1114,8 @@ static const struct aspeed_gpio_config ast2500_config = static const struct aspeed_bank_props ast2600_bank_props[] = { /* input output */ - {5, 0xffffffff, 0x0000ffff}, /* U/V/W/X */ - {6, 0xffff0000, 0x0fff0000}, /* Y/Z */ + {5, 0xffffffff, 0xffffff00}, /* U/V/W/X */ + {6, 0x0000ffff, 0x0000ffff}, /* Y/Z */ { }, }; -- 2.25.1