From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79212C41604 for ; Tue, 6 Oct 2020 07:07:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26FE320789 for ; Tue, 6 Oct 2020 07:07:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727219AbgJFHHw (ORCPT ); Tue, 6 Oct 2020 03:07:52 -0400 Received: from verein.lst.de ([213.95.11.211]:33260 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726761AbgJFHHv (ORCPT ); Tue, 6 Oct 2020 03:07:51 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 4B4C667373; Tue, 6 Oct 2020 09:07:49 +0200 (CEST) Date: Tue, 6 Oct 2020 09:07:49 +0200 From: Christoph Hellwig To: David Miller Cc: hch@lst.de, viro@zeniv.linux.org.uk, kuba@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] fs: remove ->sendpage Message-ID: <20201006070749.GA7713@lst.de> References: <20200926070049.11513-1-hch@lst.de> <20200928.151734.25122613961401605.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200928.151734.25122613961401605.davem@davemloft.net> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2020 at 03:17:34PM -0700, David Miller wrote: > From: Christoph Hellwig > Date: Sat, 26 Sep 2020 09:00:49 +0200 > > > ->sendpage is only called from generic_splice_sendpage. The only user of > > generic_splice_sendpage is socket_file_ops, which is also the only > > instance that actually implements ->sendpage. Remove the ->sendpage file > > operation and just open code the logic in the socket code. > > > > Signed-off-by: Christoph Hellwig > > Acked-by: David S. Miller Al, can you pick this up? Or give your ACK so that Dave can pick it up?