From: Peter Zijlstra <peterz@infradead.org>
To: Andy Lutomirski <luto@kernel.org>
Cc: x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Christopherson, Sean J" <sean.j.christopherson@intel.com>
Subject: Re: [PATCH 2/2] x86/entry/32: Remove leftover macros after stackprotector cleanups
Date: Tue, 6 Oct 2020 10:34:15 +0200 [thread overview]
Message-ID: <20201006083415.GO2628@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1469babd36eb342aaa5e274a73a49293fad75272.1601925251.git.luto@kernel.org>
On Mon, Oct 05, 2020 at 12:30:04PM -0700, Andy Lutomirski wrote:
> .macro SAVE_ALL pt_regs_ax=%eax switch_stacks=0 skip_gs=0 unwind_espfix=0
> cld
> .if \skip_gs == 0
> - PUSH_GS
> + pushl $0
> .endif
> pushl %fs
>
Is there a good reason not to just push gs into it? It might be nice if
pt_regs is complete.
next prev parent reply other threads:[~2020-10-06 8:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 19:30 [PATCH 0/2] Clean up x86_32 stackprotector Andy Lutomirski
2020-10-05 19:30 ` [PATCH 1/2] x86/stackprotector/32: Make the canary into a regular percpu variable Andy Lutomirski
2020-10-06 2:29 ` Sean Christopherson
2020-10-06 4:51 ` Andy Lutomirski
2020-10-06 8:26 ` Peter Zijlstra
2020-10-06 17:14 ` Brian Gerst
2020-10-07 1:16 ` Andy Lutomirski
2020-10-05 19:30 ` [PATCH 2/2] x86/entry/32: Remove leftover macros after stackprotector cleanups Andy Lutomirski
2020-10-06 8:34 ` Peter Zijlstra [this message]
2020-10-05 23:10 ` [PATCH 0/2] Clean up x86_32 stackprotector Brian Gerst
2020-10-06 8:32 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006083415.GO2628@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).