From: Sakari Ailus <sakari.ailus@iki.fi>
To: David Lu <david.lu@bitland.com.cn>
Cc: Dongchun Zhu <dongchun.zhu@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: ov8856: decrease hs_trail time
Date: Tue, 6 Oct 2020 15:58:30 +0300 [thread overview]
Message-ID: <20201006125830.GD5682@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20200727030748.3791-1-david.lu@bitland.com.cn>
Hi David,
On Mon, Jul 27, 2020 at 11:07:48AM +0800, David Lu wrote:
> To meet mipi hi speed transmission, decrease hs_trail time to pass mipi
> test.
>
> Signed-off-by: David Lu <david.lu@bitland.com.cn>
> ---
> drivers/media/i2c/ov8856.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c
> index 4ca27675cc5a..1f1835b14a24 100644
> --- a/drivers/media/i2c/ov8856.c
> +++ b/drivers/media/i2c/ov8856.c
> @@ -284,7 +284,7 @@ static const struct ov8856_reg mode_3280x2464_regs[] = {
> {0x4601, 0x80},
> {0x4800, 0x44},
> {0x4816, 0x53},
> - {0x481b, 0x58},
> + {0x481b, 0x42},
Could you elaborate a little more in the commit message what does the
register do and exactly what is changed? Is it the raw ths_trail value or
something else?
The nature of the change is such that it is very likely board specific
somehow. If you change this value for your system, does the change have
adverse effects elsewhere?
> {0x481f, 0x27},
> {0x4837, 0x16},
> {0x483c, 0x0f},
> @@ -474,7 +474,7 @@ static const struct ov8856_reg mode_1640x1232_regs[] = {
> {0x4601, 0x80},
> {0x4800, 0x44},
> {0x4816, 0x53},
> - {0x481b, 0x58},
> + {0x481b, 0x42},
> {0x481f, 0x27},
> {0x4837, 0x16},
> {0x483c, 0x0f},
--
Kind regards,
Sakari Ailus
prev parent reply other threads:[~2020-10-06 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 3:07 [PATCH] media: ov8856: decrease hs_trail time David Lu
2020-10-06 12:58 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006125830.GD5682@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=david.lu@bitland.com.cn \
--cc=dongchun.zhu@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).