From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1C7FC46466 for ; Tue, 6 Oct 2020 15:32:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58A7A206DD for ; Tue, 6 Oct 2020 15:32:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601998338; bh=OD1ShKWKDH57lAR1RIhr8UFUdjhFDgj040obC8b1vbg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=pf/b3dsEgWJ8LYokKJxNxY/slzfZVFjp/QYt0vK+IR/Nr8Ihlnx0IVISkGegkgZ8w zuqMjzPFndZmpyCKc++3YECHfnkTAUBJqNpODdZSpt7H6U4Nd+H14fYBVz03Ld0/vU uccCEZCHJR/UKm3jgb9Y+5dZVL7EJ7kVU67dNaGw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726103AbgJFPcR (ORCPT ); Tue, 6 Oct 2020 11:32:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:57282 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725769AbgJFPcR (ORCPT ); Tue, 6 Oct 2020 11:32:17 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 02EE3206D4; Tue, 6 Oct 2020 15:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601998335; bh=OD1ShKWKDH57lAR1RIhr8UFUdjhFDgj040obC8b1vbg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pfw4pAbZMMatXod0HLkTpwx5cm9AK9iAcdCbDVaUg/4Mx1J9OZfLXjdMhyDuTGjkN q0Q+JvGLvtE0saNTSE8Uey6xBof+lrGgjsG3oZ4YUje/u49Osstgc/6CH5o92Xz/JV z/L7ReAEff1KYUiPY8o+/IuSl5/Cqoqm5gOYeO7g= Date: Tue, 6 Oct 2020 17:33:01 +0200 From: Greg KH To: Bert Vermeulen Cc: tudor.ambarus@microchip.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [RESEND PATCH v2] mtd: spi-nor: Fix address width on flash chips > 16MB Message-ID: <20201006153301.GC23711@kroah.com> References: <20201006132346.12652-1-bert@biot.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201006132346.12652-1-bert@biot.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 06, 2020 at 03:23:46PM +0200, Bert Vermeulen wrote: > If a flash chip has more than 16MB capacity but its BFPT reports > BFPT_DWORD1_ADDRESS_BYTES_3_OR_4, the spi-nor framework defaults to 3. > > The check in spi_nor_set_addr_width() doesn't catch it because addr_width > did get set. This fixes that check. > > Fixes: f9acd7fa80be ("mtd: spi-nor: sfdp: default to addr_width of 3 for configurable widths") > Signed-off-by: Bert Vermeulen > Reviewed-by: Tudor Ambarus > --- > drivers/mtd/spi-nor/core.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.