From: "David E. Box" <david.e.box@linux.intel.com>
To: irenic.rajneesh@gmail.com, david.e.box@intel.com,
dvhart@infradead.org, andy@infradead.org,
gayatri.kammela@intel.com
Cc: linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Srinivas Pandruvada <srinivas.pandruvada@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"David E . Box" <david.e.box@linux.intel.com>
Subject: [PATCH 3/4] platform/x86: intel_pmc_core: fix: Replace dev_dbg macro with dev_info()
Date: Tue, 6 Oct 2020 20:51:07 -0700 [thread overview]
Message-ID: <20201007035108.31078-4-david.e.box@linux.intel.com> (raw)
In-Reply-To: <20201007035108.31078-1-david.e.box@linux.intel.com>
From: Gayatri Kammela <gayatri.kammela@intel.com>
dev_dbg macro is used to dump the debug registers in resume from an S0ix
failure. However, when CONFIG_DYNAMIC_DEBUG is not set, the user may not be
able to find the debug dump on an S0ix failure which defeats the purpose.
The output of these messages is already controlled by a module parameter,
warn_on_s0ix_failures, making it a 2 step process to enable anyway when
CONFIG_DYNAMIC_DEBUG is set.
Hence, replace dev_dbg with dev_info, allowing the control of the messages
solely through the module parameter which is N by default.
Fixes commit 913f984a8347 ("platform/x86: intel_pmc_core: Add an
additional parameter to pmc_core_lpm_display()")
Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: David E. Box <david.e.box@linux.intel.com>
Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
---
drivers/platform/x86/intel_pmc_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
index f0347ee8a4d6..a2d6f9a66428 100644
--- a/drivers/platform/x86/intel_pmc_core.c
+++ b/drivers/platform/x86/intel_pmc_core.c
@@ -636,7 +636,7 @@ static void pmc_core_slps0_display(struct pmc_dev *pmcdev, struct device *dev,
offset += 4;
while (map->name) {
if (dev)
- dev_dbg(dev, "SLP_S0_DBG: %-32s\tState: %s\n",
+ dev_info(dev, "SLP_S0_DBG: %-32s\tState: %s\n",
map->name,
data & map->bit_mask ? "Yes" : "No");
if (s)
@@ -679,7 +679,7 @@ static void pmc_core_lpm_display(struct pmc_dev *pmcdev, struct device *dev,
for (idx = 0; idx < arr_size; idx++) {
if (dev)
- dev_dbg(dev, "\nLPM_%s_%d:\t0x%x\n", str, idx,
+ dev_info(dev, "\nLPM_%s_%d:\t0x%x\n", str, idx,
lpm_regs[idx]);
if (s)
seq_printf(s, "\nLPM_%s_%d:\t0x%x\n", str, idx,
@@ -687,7 +687,7 @@ static void pmc_core_lpm_display(struct pmc_dev *pmcdev, struct device *dev,
for (index = 0; maps[idx][index].name && index < len; index++) {
bit_mask = maps[idx][index].bit_mask;
if (dev)
- dev_dbg(dev, "%-30s %-30d\n",
+ dev_info(dev, "%-30s %-30d\n",
maps[idx][index].name,
lpm_regs[idx] & bit_mask ? 1 : 0);
if (s)
--
2.20.1
next prev parent reply other threads:[~2020-10-07 3:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 3:51 [PATCH 0/4] pmc_core: Add RocketLake and other changes David E. Box
2020-10-07 3:51 ` [PATCH 1/4] platform/x86: intel_pmc_core: Clean up: Remove the duplicate comments and reorganize David E. Box
2020-10-07 3:51 ` [PATCH 2/4] platform/x86: intel_pmc_core: Add Intel RocketLake (RKL) support David E. Box
2020-10-07 15:47 ` Rajneesh Bhardwaj
2020-10-07 3:51 ` David E. Box [this message]
2020-10-07 3:51 ` [PATCH 4/4] MAINTAINERS: Update maintainers for pmc_core driver David E. Box
2020-10-07 12:13 ` [PATCH 0/4] pmc_core: Add RocketLake and other changes Andy Shevchenko
2020-10-07 21:14 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007035108.31078-4-david.e.box@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@infradead.org \
--cc=david.e.box@intel.com \
--cc=dvhart@infradead.org \
--cc=gayatri.kammela@intel.com \
--cc=irenic.rajneesh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).