From: Christoph Hellwig <firstname.lastname@example.org> To: Kees Cook <email@example.com> Cc: Christoph Hellwig <firstname.lastname@example.org>, WeiXiong Liao <email@example.com>, firstname.lastname@example.org Subject: Re: use case for register_pstore_blk? Date: Wed, 7 Oct 2020 09:37:39 +0200 Message-ID: <20201007073739.GA11745@lst.de> (raw) In-Reply-To: <202010070007.8FF59EC42@keescook> On Wed, Oct 07, 2020 at 12:13:27AM -0700, Kees Cook wrote: > On Tue, Oct 06, 2020 at 05:52:20PM +0200, Christoph Hellwig wrote: > > Hi WeiXiong, hi Kees, > > > > what is the use case for the code added in commit 17639f67c1d6 > > ("pstore/blk: Introduce backend for block devices"). > > > > This still doesn't have a user, and the API looks really odd to me. > > pstore is a beast. :) The API is there so that a blk device can declare > its direct support of pstore (specifically, to provide a panic_write > handler). > > The MTD device does this, but yes, that's a good point, there isn't a > blk device user of that entry point yet. > > > By our normal kernel rules we should not add new exports without > > users and this should probably be reverted for the 5.9 release. > > I don't want to revert the entire patch (I'm still using > __register_pstore_blk by way of pstore/blk's "best_effort" option), but > I wouldn't object to something like this: That is a minimum. But the MTD support is also completely and utterly broken as well, by declaring on-stack struct file and struct file_operations instances instead of actually reusing the block layer code. This kind of stuff really needs more coordination with the block layer and maintainers instead of the crap that ended up being merged.
next prev parent reply index Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-06 15:52 Christoph Hellwig 2020-10-07 7:13 ` Kees Cook 2020-10-07 7:37 ` Christoph Hellwig [this message] 2020-10-07 7:55 ` Christoph Hellwig 2020-10-07 8:37 ` Christoph Hellwig 2020-10-07 18:40 ` Kees Cook 2020-10-07 18:42 ` Christoph Hellwig 2020-10-07 19:17 ` Kees Cook 2020-10-12 7:02 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201007073739.GA11745@lst.de \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ email@example.com public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git