LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
	gregkh@linuxfoundation.org, rafael@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 04/11] drivers/base/devcoredump: convert devcd_count to counter_atomic32
Date: Wed, 7 Oct 2020 13:43:22 -0700
Message-ID: <202010071334.8298F3FA7@keescook> (raw)
In-Reply-To: <f27149d6b9b781ccf9c2fa041082c134abccd925.camel@sipsolutions.net>

On Wed, Oct 07, 2020 at 09:38:47PM +0200, Johannes Berg wrote:
> On Wed, 2020-10-07 at 13:33 -0600, Shuah Khan wrote:
> > On 10/7/20 12:15 PM, Kees Cook wrote:
> > > On Tue, Oct 06, 2020 at 02:44:35PM -0600, Shuah Khan wrote:
> > > > counter_atomic* is introduced to be used when a variable is used as
> > > > a simple counter and doesn't guard object lifetimes. This clearly
> > > > differentiates atomic_t usages that guard object lifetimes.
> > > > 
> > > > counter_atomic* variables will wrap around to 0 when it overflows and
> > > > should not be used to guard resource lifetimes, device usage and
> > > > open counts that control state changes, and pm states.
> > > > 
> > > > devcd_count is used to track dev_coredumpm device count and used in
> > > > device name string. It doesn't guard object lifetimes, device usage
> > > > counts, device open counts, and pm states. There is very little chance
> > > > of this counter overflowing. Convert it to use counter_atomic32.
> > > > 
> > > > This conversion doesn't change the overflow wrap around behavior.
> > > > 
> > > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> > > 
> > > I actually wonder if this should use refcount_t just because it is
> > > designed to be an alway-unique value. It is hard to imagine ever causing
> > > this to overflow, but why not let it be protected?
> > > 
> > 
> > This is one of the cases where devcd_count doesn't guard lifetimes,
> > however if it ever overflows, refcount_t is a better choice.
> > 
> > If we decide refcount_t is a better choice, I can drop this patch
> > and send refcount_t conversion patch instead.
> > 
> > Greg! Any thoughts on refcount_t for this being a better choice?
> 
> I'm not Greg, but ... there's a 5 minute timeout. So in order to cause a
> clash you'd have to manage to overflow the counter within a 5 minute
> interval, otherwise you can actually reuse the numbers starting again
> from 0 without any ill effect.

That's not true as far as I can see: there's no reset in here. It's a
global heap variable with function-level visibility (note the "static"),
so it is only ever initialized once:

void dev_coredumpm(struct device *dev, struct module *owner,
                   void *data, size_t datalen, gfp_t gfp,
                   ssize_t (*read)(char *buffer, loff_t offset, size_t count,
                                   void *data, size_t datalen),
                   void (*free)(void *data))
{
        static atomic_t devcd_count = ATOMIC_INIT(0);
	...
        dev_set_name(&devcd->devcd_dev, "devcd%d",
                     atomic_inc_return(&devcd_count));
	...
}

https://godbolt.org/z/T6Wfcj

-- 
Kees Cook

  parent reply index

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 20:44 [PATCH v2 00/11] Introduce Simple atomic counters Shuah Khan
2020-10-06 20:44 ` [PATCH v2 01/11] counters: Introduce counter_atomic* counters Shuah Khan
2020-10-07  9:04   ` Greg KH
2020-10-08 17:18     ` Shuah Khan
2020-10-07 18:11   ` Kees Cook
2020-10-07 19:26     ` Shuah Khan
2020-10-07 20:30       ` Kees Cook
2020-10-06 20:44 ` [PATCH v2 02/11] selftests:lib:test_counters: add new test for counters Shuah Khan
2020-10-07 18:12   ` Kees Cook
2020-10-06 20:44 ` [PATCH v2 03/11] drivers/base: convert deferred_trigger_count and probe_count to counter_atomic32 Shuah Khan
2020-10-07 18:13   ` Kees Cook
2020-10-06 20:44 ` [PATCH v2 04/11] drivers/base/devcoredump: convert devcd_count " Shuah Khan
2020-10-07 18:15   ` Kees Cook
2020-10-07 19:33     ` Shuah Khan
2020-10-07 19:38       ` Johannes Berg
2020-10-07 19:59         ` Shuah Khan
2020-10-07 20:43         ` Kees Cook [this message]
2020-10-08  6:42           ` Johannes Berg
2020-10-08  7:37             ` Kees Cook
2020-10-06 20:44 ` [PATCH v2 05/11] drivers/acpi: convert seqno counter_atomic32 Shuah Khan
2020-10-07 18:16   ` Kees Cook
2020-10-06 20:44 ` [PATCH v2 06/11] drivers/acpi/apei: " Shuah Khan
2020-10-07 18:17   ` Kees Cook
2020-10-06 20:44 ` [PATCH v2 07/11] drivers/android/binder: convert stats, transaction_log to counter_atomic32 Shuah Khan
2020-10-07 18:18   ` Kees Cook
2020-10-09 12:39   ` Christian Brauner
2020-10-06 20:44 ` [PATCH v2 08/11] drivers/base/test/test_async_driver_probe: convert to use counter_atomic32 Shuah Khan
2020-10-07 18:20   ` Kees Cook
2020-10-06 20:44 ` [PATCH v2 09/11] drivers/char/ipmi: convert stats " Shuah Khan
2020-10-07 18:21   ` Kees Cook
2020-10-06 20:44 ` [PATCH v2 10/11] drivers/misc/vmw_vmci: convert num guest devices counter to counter_atomic32 Shuah Khan
2020-10-07 18:27   ` Kees Cook
2020-10-08 17:12     ` Shuah Khan
2020-10-06 20:44 ` [PATCH v2 11/11] drivers/edac: convert pci counters " Shuah Khan
2020-10-07 18:28   ` Kees Cook
2020-10-07 18:30 ` [PATCH v2 00/11] Introduce Simple atomic counters Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202010071334.8298F3FA7@keescook \
    --to=keescook@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git