From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2C1FC47095 for ; Wed, 7 Oct 2020 14:18:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 400A7217BA for ; Wed, 7 Oct 2020 14:18:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728614AbgJGOSQ (ORCPT ); Wed, 7 Oct 2020 10:18:16 -0400 Received: from verein.lst.de ([213.95.11.211]:37520 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728177AbgJGOSP (ORCPT ); Wed, 7 Oct 2020 10:18:15 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C94C76736F; Wed, 7 Oct 2020 16:18:12 +0200 (CEST) Date: Wed, 7 Oct 2020 16:18:12 +0200 From: Christoph Hellwig To: Arnd Bergmann Cc: Mauro Carvalho Chehab , Christoph Hellwig , Sakari Ailus , Hans Verkuil , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: atomisp: stop compiling compat_ioctl32 code Message-ID: <20201007141812.GA1578@lst.de> References: <20201007141702.655724-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201007141702.655724-1-arnd@arndb.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2020 at 04:16:39PM +0200, Arnd Bergmann wrote: > Alternatively, the entire file could just be removed, since anyone > willing to restore the functionality can equally well just look up > the contents in the git history if needed. I suspect that is the right thing. Note that given that the driver is only in staging anyway, the right thing to do would be to change the ioctl ABI to be more compat friendly to start with.