linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linuxarm@huawei.com, mauro.chehab@huawei.com,
	John Stultz <john.stultz@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Derek Kiernan <derek.kiernan@xilinx.com>,
	Dragan Cvetic <dragan.cvetic@xilinx.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: Kconfig: add a new dependency for HISI_HIKEY_USB
Date: Thu, 8 Oct 2020 07:35:28 +0200	[thread overview]
Message-ID: <20201008073528.6cc14961@coco.lan> (raw)
In-Reply-To: <2992583d-1954-b329-86bc-c61aa35040dd@infradead.org>

Em Wed, 7 Oct 2020 19:52:56 -0700
Randy Dunlap <rdunlap@infradead.org> escreveu:

> On 10/7/20 7:18 PM, Nathan Chancellor wrote:
> > On Wed, Oct 07, 2020 at 07:09:54AM +0200, Mauro Carvalho Chehab wrote:  
> >> As warned by Randy:
> >>
> >> 	on x86_64:
> >> 	CONFIG_USB_ROLE_SWITCH=m
> >> 	and HISI_HIKEY_USB=y.
> >>
> >> 	ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_remove':
> >> 	hisi_hikey_usb.c:(.text+0x61): undefined reference to `usb_role_switch_unregister'
> >> 	ld: hisi_hikey_usb.c:(.text+0xa4): undefined reference to `usb_role_switch_put'
> >> 	ld: drivers/misc/hisi_hikey_usb.o: in function `hub_usb_role_switch_set':
> >> 	hisi_hikey_usb.c:(.text+0xd3): undefined reference to `usb_role_switch_get_drvdata'
> >> 	ld: drivers/misc/hisi_hikey_usb.o: in function `relay_set_role_switch':
> >> 	hisi_hikey_usb.c:(.text+0x54d): undefined reference to `usb_role_switch_set_role'
> >> 	ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_probe':
> >> 	hisi_hikey_usb.c:(.text+0x8a5): undefined reference to `usb_role_switch_get'
> >> 	ld: hisi_hikey_usb.c:(.text+0xa08): undefined reference to `usb_role_switch_register'
> >> 	ld: hisi_hikey_usb.c:(.text+0xa6e): undefined reference to `usb_role_switch_put'
> >>
> >> Make it dependent on CONFIG_USB_ROLE_SWITCH.
> >>
> >> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> >> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> >> ---
> >>  drivers/misc/Kconfig | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> >> index e19e1dcceb41..7cee2b72c09e 100644
> >> --- a/drivers/misc/Kconfig
> >> +++ b/drivers/misc/Kconfig
> >> @@ -459,6 +459,7 @@ config PVPANIC
> >>  config HISI_HIKEY_USB
> >>  	tristate "USB GPIO Hub on HiSilicon Hikey 960/970 Platform"
> >>  	depends on (OF && GPIOLIB) || COMPILE_TEST
> >> +	depends on CONFIG_USB_ROLE_SWITCH  
> > 
> > Shouldn't this be
> > 
> > depends on USB_ROLE_SWITCH  
> 
> Obviously. Thanks for catching that.
> 
> > ? Now it will never be selectable.

Thanks for catching this one! Sent a v2 fixing this.
(and double-checked that the driver was built after the
changes).

Thanks,
Mauro

  reply	other threads:[~2020-10-08  5:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 12:12 linux-next: Tree for Oct 6 Stephen Rothwell
2020-10-06 18:54 ` linux-next: Tree for Oct 6 (sound/soc/intel/catpt/device.c) Randy Dunlap
2020-10-06 19:35   ` Randy Dunlap
2020-10-06 19:29 ` linux-next: Tree for Oct 6 (drivers/misc/hisi_hikey_usb.c) Randy Dunlap
2020-10-07  0:10   ` John Stultz
2020-10-07  5:09     ` [PATCH] misc: Kconfig: add a new dependency for HISI_HIKEY_USB Mauro Carvalho Chehab
2020-10-07  5:53       ` Randy Dunlap
2020-10-08  2:18       ` Nathan Chancellor
2020-10-08  2:52         ` Randy Dunlap
2020-10-08  5:35           ` Mauro Carvalho Chehab [this message]
2020-10-08  4:54         ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201008073528.6cc14961@coco.lan \
    --to=mchehab+huawei@kernel.org \
    --cc=arnd@arndb.de \
    --cc=derek.kiernan@xilinx.com \
    --cc=dragan.cvetic@xilinx.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mani@kernel.org \
    --cc=mauro.chehab@huawei.com \
    --cc=natechancellor@gmail.com \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).