linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Michael Petlan <mpetlan@redhat.com>,
	Stephane Eranian <eranian@google.com>
Subject: Re: [PATCHv2 1/9] perf tools: Add build id shell test
Date: Thu, 8 Oct 2020 11:11:53 +0200	[thread overview]
Message-ID: <20201008091153.GB656950@krava> (raw)
In-Reply-To: <CAM9d7cgoaU4wcid46+uScFcZtMZZQR+fijuE7XO1mjC2cLwX-A@mail.gmail.com>

On Tue, Oct 06, 2020 at 10:37:45AM +0900, Namhyung Kim wrote:
> On Sat, Oct 3, 2020 at 4:29 AM Jiri Olsa <jolsa@redhat.com> wrote:
> >
> > On Fri, Oct 02, 2020 at 10:34:51AM -0700, Ian Rogers wrote:
> >
> > SNIP
> >
> > > > > +
> > > > >  LIBJVMTI = libperf-jvmti.so
> > > > >
> > > > >  ifndef NO_JVMTI
> > > > > @@ -756,6 +763,13 @@ $(OUTPUT)perf-read-vdsox32: perf-read-vdso.c util/find-map.c
> > > > >         $(QUIET_CC)$(CC) -mx32 $(filter -static,$(LDFLAGS)) -Wall -Werror -o $@ perf-read-vdso.c
> > > > >  endif
> > > > >
> > > > > +ifndef NO_BUILDID_EX
> > > > > +$(OUTPUT)buildid-ex-sha1:
> > > > > +       $(QUIET_LINK)echo 'int main(void) { return 0; }' | $(CC) -Wl,--build-id=sha1 -o $@ -x c -
> > > > > +$(OUTPUT)buildid-ex-md5:
> > > > > +       $(QUIET_LINK)echo 'int main(void) { return 0; }' | $(CC) -Wl,--build-id=md5 -o $@ -x c -
> > > > > +endif
> > > >
> > > > Can we just build them in the test shell script instead?
> >
> > it would solve the build-directory/install-directory
> > lookup search.. but it'd need to do detect compiler
> > and depend on it as Ian said
> >
> > do you have some other reason to compile it in test?
> 
> No I just wanted to make it easy to find the binaries
> and assumed a compiler is available in the test machine
> (which is not true for my company setup.... :-/)
> 
> But otherwise we should keep the binaries somewhere
> in the install directory..

hum, could we go in with the v3 and then you guys
could customize it to what would work for you?

thanks,
jirka


  reply	other threads:[~2020-10-08  9:12 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 17:15 [PATCH 0/9] perf tools: Add support for build id with different sizes Jiri Olsa
2020-09-30 17:15 ` [PATCH 1/9] perf tools: Add build id shell test Jiri Olsa
2020-10-01  2:00   ` Ian Rogers
2020-10-01  9:25     ` Jiri Olsa
2020-10-01 10:25       ` Jiri Olsa
2020-10-01 16:58         ` Ian Rogers
2020-10-01 19:05   ` [PATCHv2 " Jiri Olsa
2020-10-02 13:07     ` Namhyung Kim
2020-10-02 17:34       ` Ian Rogers
2020-10-02 19:29         ` Jiri Olsa
2020-10-06  1:37           ` Namhyung Kim
2020-10-08  9:11             ` Jiri Olsa [this message]
2020-10-08 15:22               ` Ian Rogers
2020-10-02 20:55         ` Arnaldo Carvalho de Melo
2020-10-05 15:58           ` [PATCHv3 " Jiri Olsa
2020-10-13 16:13   ` [PATCH " Arnaldo Carvalho de Melo
2020-10-13 19:15     ` Jiri Olsa
2020-09-30 17:15 ` [PATCH 2/9] perf tools: Use build_id object in dso Jiri Olsa
2020-10-01  2:01   ` Ian Rogers
2020-09-30 17:15 ` [PATCH 3/9] perf tools: Pass build_id object to filename__read_build_id Jiri Olsa
2020-10-01  5:17   ` Ian Rogers
2020-09-30 17:15 ` [PATCH 4/9] perf tools: Pass build id object to sysfs__read_build_id Jiri Olsa
2020-10-01  5:20   ` Ian Rogers
2020-09-30 17:15 ` [PATCH 5/9] perf tools: Pass build_id object to build_id__sprintf Jiri Olsa
2020-10-01  5:24   ` Ian Rogers
2020-09-30 17:15 ` [PATCH 6/9] perf tools: Pass build_id object to dso__set_build_id Jiri Olsa
2020-10-01  5:25   ` Ian Rogers
2020-09-30 17:15 ` [PATCH 7/9] perf tools: Pass build_id object to dso__build_id_equal Jiri Olsa
2020-10-01  5:25   ` Ian Rogers
2020-09-30 17:15 ` [PATCH 8/9] perf tools: Add size to struct perf_record_header_build_id Jiri Olsa
2020-10-01  5:31   ` Ian Rogers
2020-09-30 17:15 ` [PATCH 9/9] perf tools: Align buildid list output for short build ids Jiri Olsa
2020-10-01  5:35   ` Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201008091153.GB656950@krava \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@kernel.org \
    --cc=mpetlan@redhat.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).