From: Kalle Valo <kvalo@codeaurora.org>
To: trix@redhat.com
Cc: amitkarwar@gmail.com, ganapathi.bhat@nxp.com,
huxinming820@gmail.com, davem@davemloft.net, kuba@kernel.org,
natechancellor@gmail.com, ndesaulniers@google.com,
linville@tuxdriver.com, nishants@marvell.com,
rramesh@marvell.com, bzhao@marvell.com, frankh@marvell.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
Tom Rix <trix@redhat.com>
Subject: Re: mwifiex: fix double free
Date: Thu, 8 Oct 2020 10:46:43 +0000 (UTC) [thread overview]
Message-ID: <20201008104643.DF562C433A1@smtp.codeaurora.org> (raw)
In-Reply-To: <20201004131931.29782-1-trix@redhat.com>
trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> clang static analysis reports this problem:
>
> sdio.c:2403:3: warning: Attempt to free released memory
> kfree(card->mpa_rx.buf);
> ^~~~~~~~~~~~~~~~~~~~~~~
>
> When mwifiex_init_sdio() fails in its first call to
> mwifiex_alloc_sdio_mpa_buffer, it falls back to calling it
> again. If the second alloc of mpa_tx.buf fails, the error
> handler will try to free the old, previously freed mpa_rx.buf.
> Reviewing the code, it looks like a second double free would
> happen with mwifiex_cleanup_sdio().
>
> So set both pointers to NULL when they are freed.
>
> Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver")
> Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
53708f4fd9cf mwifiex: fix double free
--
https://patchwork.kernel.org/patch/11815655/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-10-08 10:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 13:19 [PATCH] wireless: mwifiex: fix double free trix
2020-10-05 17:58 ` Brian Norris
2020-10-08 10:46 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008104643.DF562C433A1@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=bzhao@marvell.com \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=frankh@marvell.com \
--cc=ganapathi.bhat@nxp.com \
--cc=huxinming820@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=rramesh@marvell.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).