From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D8A4C43457 for ; Thu, 8 Oct 2020 16:41:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1738421D7D for ; Thu, 8 Oct 2020 16:41:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731377AbgJHQlT (ORCPT ); Thu, 8 Oct 2020 12:41:19 -0400 Received: from mga05.intel.com ([192.55.52.43]:21842 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726766AbgJHQlR (ORCPT ); Thu, 8 Oct 2020 12:41:17 -0400 IronPort-SDR: 7wCIG1j6ZUQCEtyKImagUxbzrnD+qgPaz1zkaoikvKQtSrszPugdzOlNEdHQ+pa8T3gS9gmpo7 XPO3eNWdV2Mw== X-IronPort-AV: E=McAfee;i="6000,8403,9768"; a="250061447" X-IronPort-AV: E=Sophos;i="5.77,351,1596524400"; d="scan'208";a="250061447" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 09:41:16 -0700 IronPort-SDR: +8ZEaOJS5YzgJtL53kO3bUHDLC2vYYqPW0YrpuCxHqJ65QBr+1bHZuNvQSSMvwB8l0iEn6d9ao 4DWPEcjt59zw== X-IronPort-AV: E=Sophos;i="5.77,351,1596524400"; d="scan'208";a="461870258" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 09:41:16 -0700 Date: Thu, 8 Oct 2020 09:41:16 -0700 From: Ira Weiny To: Colin King Cc: Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] IB/rdmavt: Fix sizeof mismatch Message-ID: <20201008164116.GS2046448@iweiny-DESK2.sc.intel.com> References: <20201008095204.82683-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201008095204.82683-1-colin.king@canonical.com> User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2020 at 10:52:04AM +0100, Colin King wrote: > From: Colin Ian King > > An incorrect sizeof is being used, struct rvt_ibport ** is not correct, > it should be struct rvt_ibport *. Note that since ** is the same size as > * this is not causing any issues. Improve this fix by using > sizeof(*rdi->ports) as this allows us to not even reference the type > of the pointer. Also remove line breaks as the entire statement can > fit on one line. > > Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)") > Fixes: ff6acd69518e ("IB/rdmavt: Add device structure allocation") > Signed-off-by: Colin Ian King Reviewed-by: Ira Weiny > --- > drivers/infiniband/sw/rdmavt/vt.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/infiniband/sw/rdmavt/vt.c b/drivers/infiniband/sw/rdmavt/vt.c > index f904bb34477a..2d534c450f3c 100644 > --- a/drivers/infiniband/sw/rdmavt/vt.c > +++ b/drivers/infiniband/sw/rdmavt/vt.c > @@ -95,9 +95,7 @@ struct rvt_dev_info *rvt_alloc_device(size_t size, int nports) > if (!rdi) > return rdi; > > - rdi->ports = kcalloc(nports, > - sizeof(struct rvt_ibport **), > - GFP_KERNEL); > + rdi->ports = kcalloc(nports, sizeof(*rdi->ports), GFP_KERNEL); > if (!rdi->ports) > ib_dealloc_device(&rdi->ibdev); > > -- > 2.27.0 >