From: Josh Triplett <email@example.com> To: Andreas Dilger <firstname.lastname@example.org> Cc: "Theodore Y. Ts'o" <email@example.com>, "Darrick J. Wong" <firstname.lastname@example.org>, Jan Kara <email@example.com>, Linux Kernel Mailing List <firstname.lastname@example.org>, Ext4 Developers List <email@example.com> Subject: Re: ext4 regression in v5.9-rc2 from e7bfb5c9bb3d on ro fs with overlapped bitmaps Date: Thu, 8 Oct 2020 12:12:31 -0700 [thread overview] Message-ID: <20201008191231.GA44285@localhost> (raw) In-Reply-To: <F9799E9E-6AC8-4C66-B6C6-31CDFA8F55A6@dilger.ca> On Wed, Oct 07, 2020 at 08:57:12PM -0600, Andreas Dilger wrote: > On Oct 7, 2020, at 2:14 PM, Josh Triplett <firstname.lastname@example.org> wrote: > > If those aren't the right way to express that, I could potentially > > adapt. I had a similar such conversation on linux-ext4 already (about > > inline data with 128-bit inodes), which led to me choosing to abandon > > 128-byte inodes rather than try to get ext4 to support what I wanted > > with them, because I didn't want to be disruptive to ext4 for a niche > > use case. In the particular case that motivated this thread, what I was > > doing already worked in previous kernels, and it seemed reasonable to > > ask for it to continue to work in new kernels, while preserving the > > newly added checks in the new kernels. > > This was discussed in the "Inline data with 128-byte inodes?" thread > back in May. While Jan was not necessarily in favour of this, I was > actually OK with improving the ext4 code to handle this case better, > since it would (at minimum) clean up ext4 to make a clear separation > of how it is detecting data in the i_block array and the system.data > xattr, and I don't think it added any complexity to the code. > > I even posted a WIP patch to that effect, but didn't get a response back: > https://marc.info/?l=linux-ext4&m=158863275019187 My apologies, I thought I responded to that. It looks promising to me, though I wouldn't have the bandwidth to take it to completion anytime soon. > I *do* think that inline_data is an under-appreciated feature that I > would be happy to see some improvements with. I don't think that small > files are a niche use case, and if we can clean up the inline_data code > to work with 128-byte inodes I'm not against that, even though I'm not > going to use that combination of features myself. I'd love to see that happen. At the time, it seemed like too large of a change to block on, which is why I ended up deciding to switch to 256-byte inodes.
next prev parent reply other threads:[~2020-10-08 19:12 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-04 23:17 Linux 5.9-rc8 Linus Torvalds 2020-10-05 8:14 ` ext4 regression in v5.9-rc2 from e7bfb5c9bb3d on ro fs with overlapped bitmaps Josh Triplett 2020-10-05 9:46 ` Jan Kara 2020-10-05 10:16 ` Josh Triplett 2020-10-05 16:19 ` Jan Kara 2020-10-05 16:20 ` Jan Kara 2020-10-05 17:36 ` Darrick J. Wong 2020-10-06 0:04 ` Theodore Y. Ts'o 2020-10-06 0:32 ` Josh Triplett 2020-10-06 2:51 ` Darrick J. Wong 2020-10-06 3:18 ` Theodore Y. Ts'o 2020-10-06 5:03 ` Josh Triplett 2020-10-06 6:03 ` Josh Triplett 2020-10-06 13:35 ` Theodore Y. Ts'o 2020-10-07 8:03 ` Josh Triplett 2020-10-07 14:32 ` Theodore Y. Ts'o 2020-10-07 20:14 ` Josh Triplett 2020-10-08 2:10 ` Theodore Y. Ts'o 2020-10-08 17:54 ` Darrick J. Wong 2020-10-08 22:38 ` Josh Triplett 2020-10-09 2:54 ` Darrick J. Wong 2020-10-09 19:08 ` Josh Triplett 2020-10-08 22:22 ` Josh Triplett 2020-10-09 14:37 ` Theodore Y. Ts'o 2020-10-09 20:30 ` Josh Triplett 2021-01-10 18:41 ` Malicious fs images was " Pavel Machek 2021-01-11 18:51 ` Darrick J. Wong 2021-01-11 19:39 ` Eric Biggers 2021-01-12 21:43 ` Theodore Ts'o 2021-01-12 22:28 ` Pavel Machek 2021-01-13 5:09 ` Theodore Ts'o 2020-10-08 2:57 ` Andreas Dilger 2020-10-08 19:12 ` Josh Triplett [this message] 2020-10-08 19:25 ` Andreas Dilger 2020-10-08 22:28 ` Josh Triplett
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201008191231.GA44285@localhost \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: ext4 regression in v5.9-rc2 from e7bfb5c9bb3d on ro fs with overlapped bitmaps' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions on how to clone and mirror all data and code used for this inbox