From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3622C43457 for ; Thu, 8 Oct 2020 19:17:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54AE92184D for ; Thu, 8 Oct 2020 19:17:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728487AbgJHTRc (ORCPT ); Thu, 8 Oct 2020 15:17:32 -0400 Received: from foss.arm.com ([217.140.110.172]:45488 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726864AbgJHTRc (ORCPT ); Thu, 8 Oct 2020 15:17:32 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D892C1063; Thu, 8 Oct 2020 12:17:30 -0700 (PDT) Received: from bogus (unknown [10.57.53.233]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 94C0C3F70D; Thu, 8 Oct 2020 12:17:29 -0700 (PDT) Date: Thu, 8 Oct 2020 20:17:27 +0100 From: Sudeep Holla To: Etienne Carriere Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Cristian Marussi , Sudeep Holla , Vincent Guittot , Souvik Chakravarty Subject: Re: [PATCH 1/5] firmware: arm_scmi: always initialize protocols Message-ID: <20201008191727.ht26r5dnh3iwqj5n@bogus> References: <20201008143722.21888-1-etienne.carriere@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201008143722.21888-1-etienne.carriere@linaro.org> User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2020 at 04:37:18PM +0200, Etienne Carriere wrote: > Remove the IDR replacement that prevent initializing an SCMI protocol > when it has already been initialized. This is needed when there are > several SCMI agents that do implement a given SCMI protocol unless > what only the related SCMI protocol communication is initialized only > for first probed agent. > Can you please elaborate on your usecase please. What do you mean by several SCMI agents here. OSPM is the only agent we are interested here. What other agents is this driver supposed to handle here. We allocate memory in init and calling init multiple times messes up the allocated and initialised structures. So NACK for this patch as it needs more work if we need this at all. -- Regards, Sudeep