From: Sudeep Holla <sudeep.holla@arm.com>
To: Etienne Carriere <etienne.carriere@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Cristian Marussi <cristian.marussi@arm.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Souvik Chakravarty <Souvik.Chakravarty@arm.com>
Subject: Re: [PATCH 2/5] firmware: arm_scmi: fix transfer missing re-initialization
Date: Thu, 8 Oct 2020 22:18:04 +0100 [thread overview]
Message-ID: <20201008211804.soegjqsvmsgfmcne@bogus> (raw)
In-Reply-To: <20201008143722.21888-2-etienne.carriere@linaro.org>
On Thu, Oct 08, 2020 at 04:37:19PM +0200, Etienne Carriere wrote:
> Implement helper function scmi_do_xfer_again() to process consecutive
> transfers that are initialized only once with scmi_xfer_get_init()
> and hence get the pool completion and responses message length not
> reloaded regarding last completed transfer.
>
> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> ---
> drivers/firmware/arm_scmi/base.c | 2 +-
> drivers/firmware/arm_scmi/clock.c | 2 +-
> drivers/firmware/arm_scmi/common.h | 2 ++
> drivers/firmware/arm_scmi/driver.c | 10 ++++++++++
> drivers/firmware/arm_scmi/perf.c | 2 +-
> drivers/firmware/arm_scmi/sensors.c | 2 +-
> 6 files changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/base.c b/drivers/firmware/arm_scmi/base.c
> index 9853bd3c4d45..508f214baa1b 100644
> --- a/drivers/firmware/arm_scmi/base.c
> +++ b/drivers/firmware/arm_scmi/base.c
> @@ -183,7 +183,7 @@ static int scmi_base_implementation_list_get(const struct scmi_handle *handle,
> /* Set the number of protocols to be skipped/already read */
> *num_skip = cpu_to_le32(tot_num_ret);
>
> - ret = scmi_do_xfer(handle, t);
> + ret = scmi_do_xfer_again(handle, t);
> if (ret)
> break;
>
> diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c
> index c1cfe3ee3d55..9bb54c1a8d55 100644
> --- a/drivers/firmware/arm_scmi/clock.c
> +++ b/drivers/firmware/arm_scmi/clock.c
> @@ -161,7 +161,7 @@ scmi_clock_describe_rates_get(const struct scmi_handle *handle, u32 clk_id,
> /* Set the number of rates to be skipped/already read */
> clk_desc->rate_index = cpu_to_le32(tot_rate_cnt);
>
> - ret = scmi_do_xfer(handle, t);
> + ret = scmi_do_xfer_again(handle, t);
> if (ret)
> goto err;
>
> diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h
> index 37fb583f1bf5..6d4eea7b0f3e 100644
> --- a/drivers/firmware/arm_scmi/common.h
> +++ b/drivers/firmware/arm_scmi/common.h
> @@ -143,6 +143,8 @@ struct scmi_xfer {
>
> void scmi_xfer_put(const struct scmi_handle *h, struct scmi_xfer *xfer);
> int scmi_do_xfer(const struct scmi_handle *h, struct scmi_xfer *xfer);
> +int scmi_do_xfer_again(const struct scmi_handle *handle,
> + struct scmi_xfer *xfer);
> int scmi_do_xfer_with_response(const struct scmi_handle *h,
> struct scmi_xfer *xfer);
> int scmi_xfer_get_init(const struct scmi_handle *h, u8 msg_id, u8 prot_id,
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index c5dea87edf8f..887cb8249db0 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -402,6 +402,16 @@ int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer)
> return ret;
> }
>
> +int scmi_do_xfer_again(const struct scmi_handle *handle, struct scmi_xfer *xfer)
> +{
> + struct scmi_info *info = handle_to_scmi_info(handle);
> +
> + xfer->rx.len = info->desc->max_msg_size;
I am tempted to just have helper for above and use it where needed.
Or may be I just don't like the name of the function, how about
scmi_do_xfer_rxlen_reinit or anything else. Suggestions ?
> + xfer->hdr.poll_completion = false;
Do we really need the above ?
--
Regards,
Sudeep
next prev parent reply other threads:[~2020-10-08 21:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 14:37 [PATCH 1/5] firmware: arm_scmi: always initialize protocols Etienne Carriere
2020-10-08 14:37 ` [PATCH 2/5] firmware: arm_scmi: fix transfer missing re-initialization Etienne Carriere
2020-10-08 21:18 ` Sudeep Holla [this message]
2020-10-09 12:38 ` Etienne Carriere
2020-10-09 15:20 ` Sudeep Holla
2020-10-12 14:17 ` [PATCH] firmware: arm_scmi: Add missing Rx size re-initialisation Sudeep Holla
2020-10-13 9:58 ` Etienne Carriere
2020-10-13 10:16 ` Sudeep Holla
2020-10-13 10:50 ` Sudeep Holla
2020-10-08 14:37 ` [PATCH 3/5] firmware: arm_scmi: add config dependency for smc transport Etienne Carriere
2020-10-08 21:08 ` Sudeep Holla
2020-10-09 12:33 ` Etienne Carriere
2020-10-09 15:58 ` Sudeep Holla
2020-10-12 10:11 ` Etienne Carriere
2020-10-08 14:37 ` [PATCH 4/5] firmware: arm_scmi: smc transport supports multi-message pool Etienne Carriere
2020-10-08 21:11 ` Sudeep Holla
2020-10-09 12:43 ` Etienne Carriere
2020-10-09 15:17 ` Sudeep Holla
2020-10-12 8:57 ` Sudeep Holla
2020-10-12 9:12 ` Etienne Carriere
2020-10-08 14:37 ` [PATCH 5/5] firmware: arm_scmi: fix ARCH_COLD_RESET Etienne Carriere
2020-10-08 21:16 ` Sudeep Holla
2020-10-08 19:17 ` [PATCH 1/5] firmware: arm_scmi: always initialize protocols Sudeep Holla
2020-10-09 12:31 ` Etienne Carriere
2020-10-09 16:31 ` Cristian Marussi
2020-10-12 9:32 ` Sudeep Holla
2020-10-13 10:45 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008211804.soegjqsvmsgfmcne@bogus \
--to=sudeep.holla@arm.com \
--cc=Souvik.Chakravarty@arm.com \
--cc=cristian.marussi@arm.com \
--cc=etienne.carriere@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).