linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@denx.de>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH 1/4] ARM: dts: r8a7742-iwg21d-q7: Enable PCIe Controller
Date: Fri, 9 Oct 2020 09:23:50 +0200	[thread overview]
Message-ID: <20201009072350.GB10335@amd> (raw)
In-Reply-To: <20200825162718.5838-2-prabhakar.mahadev-lad.rj@bp.renesas.com>

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

Hi!

> +&pciec {
> +	/* SW2[6] determines which connector is activated
> +	 * ON = PCIe X4 (connector-J7)
> +	 * OFF = mini-PCIe (connector-J26)
> +	 */
> +	status = "okay";
> +};

Note this is wrong comment style for non-network parts of kernel.

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2020-10-09  7:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 16:27 [PATCH 0/4] iWave G21D-Q7 enable PCIe, flash, CAN and SD2 LED Lad Prabhakar
2020-08-25 16:27 ` [PATCH 1/4] ARM: dts: r8a7742-iwg21d-q7: Enable PCIe Controller Lad Prabhakar
2020-09-03 10:18   ` Geert Uytterhoeven
2020-09-03 11:18     ` Lad, Prabhakar
2020-09-03 11:29       ` Geert Uytterhoeven
2020-10-09  7:23   ` Pavel Machek [this message]
2020-10-09  9:01     ` Lad, Prabhakar
2020-08-25 16:27 ` [PATCH 2/4] ARM: dts: r8a7742-iwg21d-q7: Add SPI NOR support Lad Prabhakar
2020-09-03 11:59   ` Geert Uytterhoeven
2020-09-04 17:24     ` Lad, Prabhakar
2020-08-25 16:27 ` [PATCH 3/4] ARM: dts: r8a7742-iwg21d-q7: Add can0 support to carrier board Lad Prabhakar
2020-09-03 12:14   ` Geert Uytterhoeven
2020-09-04 17:17     ` Lad, Prabhakar
2020-08-25 16:27 ` [PATCH 4/4] ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication Lad Prabhakar
2020-09-03 12:20   ` Geert Uytterhoeven
2020-09-04 17:15     ` Lad, Prabhakar
2020-09-07  7:55       ` Geert Uytterhoeven
2020-09-07 15:23         ` Lad, Prabhakar
2020-10-09  7:26   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201009072350.GB10335@amd \
    --to=pavel@denx.de \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).