From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Xiaoming Ni <nixiaoming@huawei.com>
Cc: dima@arista.com, will@kernel.org, jpoimboe@redhat.com,
akpm@linux-foundation.org, christian.brauner@ubuntu.com,
viro@zeniv.linux.org.uk, ldufour@linux.ibm.com,
amanieu@gmail.com, walken@google.com, ben.dooks@codethink.co.uk,
tglx@linutronix.de, bigeasy@linutronix.de, mingo@kernel.org,
vincent.whitchurch@axis.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, wangle6@huawei.com,
luohaizheng@huawei.com
Subject: Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces
Date: Fri, 9 Oct 2020 09:08:50 +0100 [thread overview]
Message-ID: <20201009080849.GM1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20201009075957.110017-1-nixiaoming@huawei.com>
On Fri, Oct 09, 2020 at 03:59:57PM +0800, Xiaoming Ni wrote:
> Printing raw pointer values in backtraces has potential security
> implications and are of questionable value anyway.
>
> This patch follows x86 and arm64's lead and removes the "Exception stack:"
> dump from kernel backtraces:
> commit a25ffd3a6302a6 ("arm64: traps: Don't print stack or raw
> PC/LR values in backtraces")
> commit 0ee1dd9f5e7eae ("x86/dumpstack: Remove raw stack dump")
> commit bb5e5ce545f203 ("x86/dumpstack: Remove kernel text
> addresses from stack dump")
>
> Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
I am really not happy about this - it hurts at least my ability to
debug the kernel when people post oopses to the mailing list. If
people wish to make the kernel harder to debug, and are prepared
to be told "your kernel is undebuggable" then this patch is fine.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-10-09 8:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 7:59 [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces Xiaoming Ni
2020-10-09 8:08 ` Russell King - ARM Linux admin [this message]
2020-10-09 8:18 ` Sebastian Andrzej Siewior
2020-10-09 8:58 ` Xiaoming Ni
2020-10-11 21:32 ` Russell King - ARM Linux admin
2020-10-12 2:23 ` Xiaoming Ni
2020-10-12 10:03 ` Sebastian Andrzej Siewior
2020-10-12 11:06 ` Russell King - ARM Linux admin
2020-10-10 17:55 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009080849.GM1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=amanieu@gmail.com \
--cc=ben.dooks@codethink.co.uk \
--cc=bigeasy@linutronix.de \
--cc=christian.brauner@ubuntu.com \
--cc=dima@arista.com \
--cc=jpoimboe@redhat.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luohaizheng@huawei.com \
--cc=mingo@kernel.org \
--cc=nixiaoming@huawei.com \
--cc=tglx@linutronix.de \
--cc=vincent.whitchurch@axis.com \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
--cc=wangle6@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).