From: Wolfram Sang <wsa@kernel.org>
To: Christian Eggers <ceggers@arri.de>
Cc: "Oleksij Rempel" <linux@rempel-privat.de>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"David Laight" <David.Laight@aculab.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"NXP Linux Team" <linux-imx@nxp.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Krzysztof Kozlowski" <krzk@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v6 3/3] i2c: imx: Don't generate STOP condition if arbitration has been lost
Date: Sat, 10 Oct 2020 13:09:37 +0200 [thread overview]
Message-ID: <20201010110937.GD4669@ninjato> (raw)
In-Reply-To: <20201009110320.20832-4-ceggers@arri.de>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
On Fri, Oct 09, 2020 at 01:03:20PM +0200, Christian Eggers wrote:
> If arbitration is lost, the master automatically changes to slave mode.
> I2SR_IBB may or may not be reset by hardware. Raising a STOP condition
> by resetting I2CR_MSTA has no effect and will not clear I2SR_IBB.
>
> So calling i2c_imx_bus_busy() is not required and would busy-wait until
> timeout.
>
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> Tested (not extensively) on Vybrid VF500 (Toradex VF50):
> Tested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Cc: stable@vger.kernel.org # Requires trivial backporting, simple remove
> # the 3rd argument from the calls to
> # i2c_imx_bus_busy().
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-10-10 23:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 11:03 [PATCH v6 0/3] i2c: imx: Fix handling of arbitration loss Christian Eggers
2020-10-09 11:03 ` [PATCH v6 1/3] i2c: imx: Fix reset of I2SR_IAL flag Christian Eggers
2020-10-10 11:09 ` Wolfram Sang
2020-12-01 7:34 ` Christian Eggers
2020-12-02 15:04 ` Wolfram Sang
2020-10-09 11:03 ` [PATCH v6 2/3] i2c: imx: Check for I2SR_IAL after every byte Christian Eggers
2020-10-10 11:09 ` Wolfram Sang
2020-10-09 11:03 ` [PATCH v6 3/3] i2c: imx: Don't generate STOP condition if arbitration has been lost Christian Eggers
2020-10-10 11:09 ` Wolfram Sang [this message]
2020-10-10 11:06 ` [PATCH v6 0/3] i2c: imx: Fix handling of arbitration loss Wolfram Sang
2020-10-18 10:44 ` Christian Eggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201010110937.GD4669@ninjato \
--to=wsa@kernel.org \
--cc=David.Laight@aculab.com \
--cc=ceggers@arri.de \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=o.rempel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).