From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA27C433DF for ; Sat, 10 Oct 2020 23:08:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E5B020760 for ; Sat, 10 Oct 2020 23:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602371324; bh=RK3mSg3UX4zTOJGirJtJfigfLFSX4tQ66YyfihKPWq0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=TO9R5I1ez8AlxdTYsA1Vcto5F8wwd5b3rFxMV9LK7SNFAvKlSkACFKebqEDPveBR/ aKd6Z1BsZn5OLB6CeP3/CvislXKDEBcl71drNJJufPk6bkk0RQmor8QJ87dKKqVY1K +lsKBXZj/k2Jy0pcr50/4um8kDiGfgLDwvzHMhNw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390413AbgJJW5L (ORCPT ); Sat, 10 Oct 2020 18:57:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:54884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732189AbgJJTmt (ORCPT ); Sat, 10 Oct 2020 15:42:49 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2BDFA2222C; Sat, 10 Oct 2020 17:05:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602349554; bh=RK3mSg3UX4zTOJGirJtJfigfLFSX4tQ66YyfihKPWq0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lgdNQBBm5Q9DALcBRX7i049IJoFS9PHAlvQlT1JDOXB4LjoIJQXpexfaKTizLimoS TtFS/Fu3aXeQ59n+2IisrhBfKa0ISjqJEwMgxlcNW8wRmqgYNSPPkYnqS2NRkga+qJ zGwmtffYKUtZ12r7ConXt+NYk7kGHPr4ifuP/Cqg= Date: Sat, 10 Oct 2020 18:05:49 +0100 From: Jonathan Cameron To: Rikard Falkeborn Cc: Lars-Peter Clausen , Peter Meerwald-Stadler , Alexandru Ardelean , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: accel: mma8452: Constify static struct attribute_group Message-ID: <20201010180549.629f8102@archlinux> In-Reply-To: <20200930232939.31131-1-rikard.falkeborn@gmail.com> References: <20200930232939.31131-1-rikard.falkeborn@gmail.com> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Oct 2020 01:29:39 +0200 Rikard Falkeborn wrote: > The only usage of mma8452_event_attribute_group is to assign its address > to the event_attrs field in the iio_info struct, which is a const > pointer. Make it const to allow the compiler to put it in read-only > memory. This was the only non-const static struct in drivers/iio. > > Signed-off-by: Rikard Falkeborn applied. Thanks, Jonathan > --- > drivers/iio/accel/mma8452.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index bf1d2c8afdbd..b0176d936423 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -1187,7 +1187,7 @@ static struct attribute *mma8452_event_attributes[] = { > NULL, > }; > > -static struct attribute_group mma8452_event_attribute_group = { > +static const struct attribute_group mma8452_event_attribute_group = { > .attrs = mma8452_event_attributes, > }; >