From: trix@redhat.com
To: richardcochran@gmail.com, natechancellor@gmail.com,
ndesaulniers@google.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com, Tom Rix <trix@redhat.com>
Subject: [PATCH] ptp: ptp_clockmatrix: initialize variables
Date: Sun, 11 Oct 2020 13:09:55 -0700 [thread overview]
Message-ID: <20201011200955.29992-1-trix@redhat.com> (raw)
From: Tom Rix <trix@redhat.com>
Clang static analysis reports this representative problem
ptp_clockmatrix.c:1852:2: warning: 5th function call argument
is an uninitialized value
snprintf(idtcm->version, sizeof(idtcm->version), "%u.%u.%u",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
idtcm_display_version_info() calls several idtcm_read_*'s without
checking a return status. Initialize the read variables so if a
read fails, a garbage value is not displayed.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/ptp/ptp_clockmatrix.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
index e020faff7da5..47e5e62da5d2 100644
--- a/drivers/ptp/ptp_clockmatrix.c
+++ b/drivers/ptp/ptp_clockmatrix.c
@@ -1832,12 +1832,12 @@ static int idtcm_enable_tod(struct idtcm_channel *channel)
static void idtcm_display_version_info(struct idtcm *idtcm)
{
- u8 major;
- u8 minor;
- u8 hotfix;
- u16 product_id;
- u8 hw_rev_id;
- u8 config_select;
+ u8 major = 0;
+ u8 minor = 0;
+ u8 hotfix = 0;
+ u16 product_id = 0;
+ u8 hw_rev_id = 0;
+ u8 config_select = 0;
char *fmt = "%d.%d.%d, Id: 0x%04x HW Rev: %d OTP Config Select: %d\n";
idtcm_read_major_release(idtcm, &major);
--
2.18.1
next reply other threads:[~2020-10-11 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 20:09 trix [this message]
2020-10-12 22:01 ` [PATCH] ptp: ptp_clockmatrix: initialize variables Richard Cochran
2020-10-13 4:07 ` Tom Rix
2020-10-13 12:40 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201011200955.29992-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).