From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F351C433E7 for ; Mon, 12 Oct 2020 07:04:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5F302076E for ; Mon, 12 Oct 2020 07:04:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727045AbgJLHE0 (ORCPT ); Mon, 12 Oct 2020 03:04:26 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:57231 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727088AbgJLHEZ (ORCPT ); Mon, 12 Oct 2020 03:04:25 -0400 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id B13F6E000A; Mon, 12 Oct 2020 07:04:21 +0000 (UTC) Date: Mon, 12 Oct 2020 09:04:20 +0200 From: Miquel Raynal To: Guenter Roeck Cc: Florian Fainelli , linux-mtd@lists.infradead.org, Richard Weinberger , Vignesh Raghavendra , =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6?= Rojas , Jonas Gorski , open list Subject: Re: [PATCH] mtd: parsers: bcm63xx: Do not make it modular Message-ID: <20201012090420.6a07599c@xps13> In-Reply-To: <20201011141447.GA9215@roeck-us.net> References: <20200928161617.2a1b2244@xps13> <20200929172726.30469-1-f.fainelli@gmail.com> <20201011141447.GA9215@roeck-us.net> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, Guenter Roeck wrote on Sun, 11 Oct 2020 07:14:47 -0700: > On Tue, Sep 29, 2020 at 10:27:21AM -0700, Florian Fainelli wrote: > > With commit 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE > > detection"), we generate a reference to fw_arg3 which is the fourth > > firmware/command line argument on MIPS platforms. That symbol is not > > exported and would cause a linking failure. > > > > The parser is typically necessary to boot a BCM63xx-based system anyway > > so having it be part of the kernel image makes sense, therefore make it > > 'bool' instead of 'tristate'. > > > > Fixes: 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE detection") > > Signed-off-by: Florian Fainelli > > What happened with this patch ? The build failure is still seen in mainline > and in next-20201009. It has been applied on mtd/next: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/log/?h=mtd/next (I don't remember when though)