From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 732A7C433DF for ; Mon, 12 Oct 2020 13:37:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EE4F22248 for ; Mon, 12 Oct 2020 13:37:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602509874; bh=xu3parxoOquZtLOZWNhfKDsRWR89l6biFvMyZKIebg4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=M5/+//ukIu3+xmECx/RG/gXVYogXBpH05qi8hWY4lDK5lprGnmPMNDDivwI6lMpZG IAEpW1jyr+RqvKJKd7wRDXlBzHw6MqDa0R64yrX4a853glEtFrlhH3l52Llru1AAPh IqAB13hbj/TmBdKAQwrT6m4M+U0zNekgLPRONj9k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388709AbgJLNhv (ORCPT ); Mon, 12 Oct 2020 09:37:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:40138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730996AbgJLNhO (ORCPT ); Mon, 12 Oct 2020 09:37:14 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6CF2921BE5; Mon, 12 Oct 2020 13:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602509806; bh=xu3parxoOquZtLOZWNhfKDsRWR89l6biFvMyZKIebg4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0JWpeOrjuqtMze9sgay/BarEfer3F0kvqj0AaisYk7W5/OEhIKnYcoR+N6pW5PR0i gX3V3jbguAe7J5kNNYYxR/Jmgi5uzpp/rs7xeLiS2yb4OBbKI9TPXpTsWqnQtViLqk lY117OCW+CTT57V9jmFmpnbev1LCAi4E6w0p4FbM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vegard Nossum , Al Viro , "Eric W. Biederman" , Linus Torvalds Subject: [PATCH 4.14 37/70] usermodehelper: reset umask to default before executing user process Date: Mon, 12 Oct 2020 15:26:53 +0200 Message-Id: <20201012132631.961594032@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201012132630.201442517@linuxfoundation.org> References: <20201012132630.201442517@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Torvalds commit 4013c1496c49615d90d36b9d513eee8e369778e9 upstream. Kernel threads intentionally do CLONE_FS in order to follow any changes that 'init' does to set up the root directory (or cwd). It is admittedly a bit odd, but it avoids the situation where 'init' does some extensive setup to initialize the system environment, and then we execute a usermode helper program, and it uses the original FS setup from boot time that may be very limited and incomplete. [ Both Al Viro and Eric Biederman point out that 'pivot_root()' will follow the root regardless, since it fixes up other users of root (see chroot_fs_refs() for details), but overmounting root and doing a chroot() would not. ] However, Vegard Nossum noticed that the CLONE_FS not only means that we follow the root and current working directories, it also means we share umask with whatever init changed it to. That wasn't intentional. Just reset umask to the original default (0022) before actually starting the usermode helper program. Reported-by: Vegard Nossum Cc: Al Viro Acked-by: Eric W. Biederman Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- kernel/umh.c | 9 +++++++++ 1 file changed, 9 insertions(+) --- a/kernel/umh.c +++ b/kernel/umh.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -71,6 +72,14 @@ static int call_usermodehelper_exec_asyn spin_unlock_irq(¤t->sighand->siglock); /* + * Initial kernel threads share ther FS with init, in order to + * get the init root directory. But we've now created a new + * thread that is going to execve a user process and has its own + * 'struct fs_struct'. Reset umask to the default. + */ + current->fs->umask = 0022; + + /* * Our parent (unbound workqueue) runs with elevated scheduling * priority. Avoid propagating that into the userspace child. */