From: Maxime Ripard <maxime@cerno.tech>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Marcus Cooper <codekipper@gmail.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH v7 01/14] ASoC: sun4i-i2s: Change set_chan_cfg() params
Date: Mon, 12 Oct 2020 15:58:45 +0200 [thread overview]
Message-ID: <20201012135845.s6tknsnjrtsuoacf@gilmour.lan> (raw)
In-Reply-To: <20201011202224.47544-2-peron.clem@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
On Sun, Oct 11, 2020 at 10:22:11PM +0200, Clément Péron wrote:
> As slots and slot_width can be set manually using set_tdm().
> These values are then kept in sun4i_i2s struct.
> So we need to check if these values are set or not.
>
> This is not done actually and will trigger a bug.
> For example, if we set to the simple soundcard in the device-tree
> dai-tdm-slot-width = <32> and then start a stream using S16_LE,
> currently we would calculate BCLK for 32-bit slots, but program
> lrck_period for 16-bit slots, making the sample rate double what we
> expected.
>
> To fix this, we need to check if these values are set or not but as
> this logic is already done by the caller. Avoid duplicating this
> logic and just pass the required values as params to set_chan_cfg().
>
> Suggested-by: Samuel Holland <samuel@sholland.org>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
We still have an ongoing discussion on this one in the v6
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-10-12 13:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 20:22 [PATCH v7 00/14] Add Allwinner H3/H5/H6/A64 HDMI audio Clément Péron
2020-10-11 20:22 ` [PATCH v7 01/14] ASoC: sun4i-i2s: Change set_chan_cfg() params Clément Péron
2020-10-12 13:58 ` Maxime Ripard [this message]
2020-10-11 20:22 ` [PATCH v7 02/14] ASoC: sun4i-i2s: Add support for H6 I2S Clément Péron
2020-10-11 20:22 ` [PATCH v7 03/14] ASoC: sun4i-i2s: Change get_sr() and get_wss() to be more explicit Clément Péron
2020-10-11 20:22 ` [PATCH v7 04/14] ASoC: sun4i-i2s: Set sign extend sample Clément Péron
2020-10-11 20:22 ` [PATCH v7 05/14] ASoc: sun4i-i2s: Add 20 and 24 bit support Clément Péron
2020-10-11 20:22 ` [PATCH v7 06/14] ASoC: sun4i-i2s: Fix sun8i volatile regs Clément Péron
2020-10-11 20:22 ` [PATCH v7 07/14] ASoC: sun4i-i2s: Fix setting of FIFO modes Clément Péron
2020-10-11 20:22 ` [PATCH v7 08/14] ASoC: sun4i-i2s: fix coding-style for callback definition Clément Péron
2020-10-11 20:22 ` [PATCH v7 09/14] dt-bindings: ASoC: sun4i-i2s: Add H6 compatible Clément Péron
2020-10-11 20:22 ` [PATCH v7 10/14] arm64: dts: allwinner: h6: Add I2S1 node Clément Péron
2020-10-11 20:22 ` [PATCH v7 11/14] arm64: dts: allwinner: a64: Add I2S2 node Clément Péron
2020-10-11 20:22 ` [PATCH v7 12/14] arm64: defconfig: Enable Allwinner i2s driver Clément Péron
2020-10-11 20:22 ` [PATCH v7 13/14] dt-bindings: sound: sun4i-i2s: Document H3 with missing RX channel possibility Clément Péron
2020-10-11 20:22 ` [PATCH v7 14/14] arm: dts: sunxi: h3/h5: Add I2S2 node Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012135845.s6tknsnjrtsuoacf@gilmour.lan \
--to=maxime@cerno.tech \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=perex@perex.cz \
--cc=peron.clem@gmail.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).