From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 091D7C433DF for ; Mon, 12 Oct 2020 18:57:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFE57208D5 for ; Mon, 12 Oct 2020 18:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602529061; bh=TA+nRrZByFjgZy0niE7kTvrlc4xfkBx/o1wkgvNOsf4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=RAG1B7YDQhqLf5EtD6CZbj/L1B7S4reZ5dbvvr6CC9t/Mw7QK66L53Ch9bt/SYJBr nhAI5zMaACbhnTV3e4oLuKJ+li5oY+LmyE2qd8nyickgtRcrode38XQpnNzVKsJx0l vF9xLC/W1PIdUzdCIgIulvCcpw8X8i7TBBqmN2Ww= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730818AbgJLS5k (ORCPT ); Mon, 12 Oct 2020 14:57:40 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:35964 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727115AbgJLS5k (ORCPT ); Mon, 12 Oct 2020 14:57:40 -0400 Received: by mail-ot1-f67.google.com with SMTP id 32so3598551otm.3; Mon, 12 Oct 2020 11:57:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ddIV4HQN24CafNYgtjScHKXn58YYBc4ENbBdZztl7Po=; b=hW7NKjPA9XmDVlbiDZ1SzZSr2fz9arPeXwoM6C4WyojbDOlmGpgEnA9bH+EOF2CZl6 1rOP+iwS24Wz6dH22xVMUXMi+06Qzwzg3LL1YXv6hf5nLc9nuXTSO2QhO/A3tG/Wl+kK qVOjp2W03a1DJTWfRv58rYuj6iDXMICFyEPZigqFCVVoZpYmmQB7eb8/DB0P/eLAhBrx OSDMbGqMAkoIXaTu+LEBCzkY4aq5gOSG9mGeEvG4VaNzaAHwPDTghPTHp1NpO5DLivl2 KKGZ7rflgmGEay4FjBYZ+6v8nafGaLbqlw8itWDqQCKj3mEwmIVIr3+gzwGp8j6N6v6F FxHQ== X-Gm-Message-State: AOAM532LzNDepTE0LNhwz8YUoHqXm50RSD6bb5hbLOr2O8d5EwkgcMKE H9RxgiFMKF48/kztPruufe/aPS5RBbFO X-Google-Smtp-Source: ABdhPJw4IVll4ULsuJ5LXi+mVD/6wjOwgXKHePUC517QdcqQleAXdmNv1FWoCkkbRyTDphEGrvoV1g== X-Received: by 2002:a05:6830:1e19:: with SMTP id s25mr18618580otr.294.1602529058807; Mon, 12 Oct 2020 11:57:38 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 81sm9006727oti.79.2020.10.12.11.57.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 11:57:38 -0700 (PDT) Received: (nullmailer pid 1908487 invoked by uid 1000); Mon, 12 Oct 2020 18:57:37 -0000 Date: Mon, 12 Oct 2020 13:57:37 -0500 From: Rob Herring To: Vinod Koul Cc: dmaengine@vger.kernel.org, Bjorn Andersson , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Ujfalusi Subject: Re: [PATCH v4 1/3] dt-bindings: dmaengine: Document qcom,gpi dma binding Message-ID: <20201012185737.GA1905980@bogus> References: <20201008123151.764238-1-vkoul@kernel.org> <20201008123151.764238-2-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201008123151.764238-2-vkoul@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2020 at 06:01:49PM +0530, Vinod Koul wrote: > Add devicetree binding documentation for GPI DMA controller > implemented on Qualcomm SoCs > > Signed-off-by: Vinod Koul > --- > .../devicetree/bindings/dma/qcom,gpi.yaml | 86 +++++++++++++++++++ > include/dt-bindings/dma/qcom-gpi.h | 11 +++ > 2 files changed, 97 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/qcom,gpi.yaml > create mode 100644 include/dt-bindings/dma/qcom-gpi.h > > diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml > new file mode 100644 > index 000000000000..4470c1b2fd6c > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml > @@ -0,0 +1,86 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/qcom,gpi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies Inc GPI DMA controller > + > +maintainers: > + - Vinod Koul > + > +description: | > + QCOM GPI DMA controller provides DMA capabilities for > + peripheral buses such as I2C, UART, and SPI. > + > +allOf: > + - $ref: "dma-controller.yaml#" > + > +properties: > + compatible: > + enum: > + - qcom,sdm845-gpi-dma > + > + reg: > + maxItems: 1 > + > + interrupts: > + description: > + Interrupt lines for each GPI instance > + maxItems: 13 > + > + "#dma-cells": > + const: 3 > + description: > > + DMA clients must use the format described in dma.txt, giving a phandle > + to the DMA controller plus the following 3 integer cells: > + - channel: if set to 0xffffffff, any available channel will be allocated > + for the client. Otherwise, the exact channel specified will be used. > + - seid: serial id of the client as defined in the SoC documentation. > + - client: type of the client as defined in dt-bindings/dma/qcom-gpi.h > + > + iommus: > + maxItems: 1 > + > + dma-channels: > + maximum: 31 > + > + dma-channel-mask: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - "#dma-cells" > + - iommus > + - dma-channels > + - dma-channel-mask additionalProperties: false With that, Reviewed-by: Rob Herring > + > +examples: > + - | > + #include > + #include > + gpi_dma0: dma-controller@800000 { > + compatible = "qcom,gpi-dma"; > + #dma-cells = <3>; > + reg = <0x00800000 0x60000>; > + iommus = <&apps_smmu 0x0016 0x0>; > + dma-channels = <13>; > + dma-channel-mask = <0xfa>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > +... > diff --git a/include/dt-bindings/dma/qcom-gpi.h b/include/dt-bindings/dma/qcom-gpi.h > new file mode 100644 > index 000000000000..71f79eb7614c > --- /dev/null > +++ b/include/dt-bindings/dma/qcom-gpi.h > @@ -0,0 +1,11 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* Copyright (c) 2020, Linaro Ltd. */ > + > +#ifndef __DT_BINDINGS_DMA_QCOM_GPI_H__ > +#define __DT_BINDINGS_DMA_QCOM_GPI_H__ > + > +#define QCOM_GPI_SPI 1 > +#define QCOM_GPI_UART 2 > +#define QCOM_GPI_I2C 3 > + > +#endif /* __DT_BINDINGS_DMA_QCOM_GPI_H__ */ > -- > 2.26.2 >