From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72168C43457 for ; Tue, 13 Oct 2020 14:31:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 125AF20797 for ; Tue, 13 Oct 2020 14:31:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="X0en6LF+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388710AbgJMObx (ORCPT ); Tue, 13 Oct 2020 10:31:53 -0400 Received: from linux.microsoft.com ([13.77.154.182]:33458 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387516AbgJMObu (ORCPT ); Tue, 13 Oct 2020 10:31:50 -0400 Received: from sequoia (162-237-133-238.lightspeed.rcsntx.sbcglobal.net [162.237.133.238]) by linux.microsoft.com (Postfix) with ESMTPSA id 6AD9320B4905; Tue, 13 Oct 2020 07:31:49 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6AD9320B4905 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1602599509; bh=qJXh+57+9TzB1CrROf86VFJLVGLi7eRc1KhHpcNMGas=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X0en6LF+5k0tk23ICRKWKqwz2HLlzl+tCBaeY49/dCPVnYZ+AgHzzFqKjXozcod+u rmvtdNn2Pbz3Xvj+oJDtCnJwufIrWum85l+EPVxKlnAYu8Tk2S8n49m/JrDWJEcpp2 8fYfBrALywgoH26onkezASyihEEyojCfkjgg1wNk= Date: Tue, 13 Oct 2020 09:31:39 -0500 From: Tyler Hicks To: Jarkko Sakkinen Cc: Kai-Heng Feng , Mimi Zohar , linux-integrity@vger.kernel.org, open list Subject: Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference Message-ID: <20201013143139.GA12418@sequoia> References: <20200928140623.GA69515@linux.intel.com> <846fe4da67d05f57fba33e38c9a6e394e657adc3.camel@linux.ibm.com> <20200930022040.GG808399@linux.intel.com> <20201009160654.GA26881@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201009160654.GA26881@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry for coming in so late, I've been on an extended vacation with little connectivity. On 2020-10-09 19:06:54, Jarkko Sakkinen wrote: > On Thu, Oct 08, 2020 at 05:09:06PM +0800, Kai-Heng Feng wrote: > > > I do not have yet any reasonable answer to this and my v5.10 PR is > > > running late. Does everyone agree that I should revert the patch? > > > > Given that there are multiple users confirmed reverting the commit > > helps, can you please revert it and Cc: linux-stable? > > I already sent the PR, but I schedule the revert to my rc2 PR. I'll try to better understand what's going on. I, too, am confused about how the change would introduce the reported regression. I've only skimmed the thread so far but it feels like there's possibly a latent issue that the change may be uncovering on certain systems. FWIW, we've had this patch applied to our internal kernel for a month and haven't seen any issues. Tyler > > > Thanks! > > > > Kai-Heng > > /Jarkko >