linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: Nilesh Javali <njavali@marvell.com>,
	Arun Easi <aeasi@marvell.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] qla2xxx: Return EBUSY on fcport deletion
Date: Wed, 14 Oct 2020 09:06:31 +0200	[thread overview]
Message-ID: <20201014070631.oe7hbjtfhsohgr54@beryllium.lan> (raw)
In-Reply-To: <alpine.LNX.2.23.453.2010141103150.6@nippy.intranet>

Hi Finn,

On Wed, Oct 14, 2020 at 11:57:04AM +1100, Finn Thain wrote:
> 
> On Tue, 13 Oct 2020, Daniel Wagner wrote:
> > How so? I am struggling to see how it could be a change in behavior. But 
> > then I sometimes fail at simple logic ;)
> > 
> 
> Me too, so I confirmed the result by executing the code snippets.

Thanks for taking the time to explain it to me!

> I don't know whether the changes in v3 are desirable or not, I was just 
> pointing out that the commit log ("valid qpair but the firmware has not 
> yet started return EBUSY") now seems to disagree with the code.

I see where I did my thinko. In v3 we have more ENODEV due to the fact
that we test the pointers first (qpair, fpcort). If either of them is
invalid we get the ENODEV. Actually, it's makes more sense and is likely
to be 'more correct'.

Anyway, let me update the commit log.

Thanks a lot!
Daniel

      reply	other threads:[~2020-10-14  7:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 17:35 [PATCH v3] qla2xxx: Return EBUSY on fcport deletion Daniel Wagner
2020-10-12 18:14 ` [EXT] " Arun Easi
2020-10-12 23:59 ` Finn Thain
2020-10-13  6:52   ` Daniel Wagner
2020-10-14  0:57     ` Finn Thain
2020-10-14  7:06       ` Daniel Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201014070631.oe7hbjtfhsohgr54@beryllium.lan \
    --to=dwagner@suse.de \
    --cc=aeasi@marvell.com \
    --cc=fthain@telegraphics.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=njavali@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).