From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 450D7C433E7 for ; Thu, 15 Oct 2020 08:32:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E327922249 for ; Thu, 15 Oct 2020 08:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729596AbgJOIcg (ORCPT ); Thu, 15 Oct 2020 04:32:36 -0400 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:44903 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728436AbgJOIcg (ORCPT ); Thu, 15 Oct 2020 04:32:36 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R621e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=richard.weiyang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UC5T.KF_1602750754; Received: from localhost(mailfrom:richard.weiyang@linux.alibaba.com fp:SMTPD_---0UC5T.KF_1602750754) by smtp.aliyun-inc.com(127.0.0.1); Thu, 15 Oct 2020 16:32:34 +0800 Date: Thu, 15 Oct 2020 16:32:34 +0800 From: Wei Yang To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org, Andrew Morton , "Michael S . Tsirkin" , Jason Wang , Pankaj Gupta Subject: Re: [PATCH v1 06/29] virtio-mem: generalize virtio_mem_owned_mb() Message-ID: <20201015083234.GF86495@L-31X9LVDL-1304.local> Reply-To: Wei Yang References: <20201012125323.17509-1-david@redhat.com> <20201012125323.17509-7-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201012125323.17509-7-david@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2020 at 02:53:00PM +0200, David Hildenbrand wrote: >Avoid using memory block ids. Rename it to virtio_mem_contains_range(). > >Cc: "Michael S. Tsirkin" >Cc: Jason Wang >Cc: Pankaj Gupta >Signed-off-by: David Hildenbrand >--- > drivers/virtio/virtio_mem.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > >diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c >index 6bbd1cfd10d3..821143db14fe 100644 >--- a/drivers/virtio/virtio_mem.c >+++ b/drivers/virtio/virtio_mem.c >@@ -500,12 +500,13 @@ static bool virtio_mem_overlaps_range(struct virtio_mem *vm, > } > > /* >- * Test if a virtio-mem device owns a memory block. Can be called from >+ * Test if a virtio-mem device contains a given range. Can be called from > * (notifier) callbacks lockless. > */ >-static bool virtio_mem_owned_mb(struct virtio_mem *vm, unsigned long mb_id) >+static bool virtio_mem_contains_range(struct virtio_mem *vm, uint64_t start, >+ uint64_t size) > { >- return mb_id >= vm->first_mb_id && mb_id <= vm->last_mb_id; >+ return start >= vm->addr && start + size <= vm->addr + vm->region_size; Do we have some reason to do this change? > } > > static int virtio_mem_notify_going_online(struct virtio_mem *vm, >@@ -800,7 +801,7 @@ static void virtio_mem_online_page_cb(struct page *page, unsigned int order) > */ > rcu_read_lock(); > list_for_each_entry_rcu(vm, &virtio_mem_devices, next) { >- if (!virtio_mem_owned_mb(vm, mb_id)) >+ if (!virtio_mem_contains_range(vm, addr, PFN_PHYS(1 << order))) > continue; > > sb_id = virtio_mem_phys_to_sb_id(vm, addr); >-- >2.26.2 -- Wei Yang Help you, Help me