From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4911EC433DF for ; Thu, 15 Oct 2020 08:36:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9E872224E for ; Thu, 15 Oct 2020 08:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602750973; bh=hP94CwWS7xvhTtF8wHiWx81RZLTLeMuk1epq5z2bU60=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=K+FdwIE68Vh1LHG/3tmFBBNUyLBA/sUGz3KUXa6+trW/tUO5h3bTbmnEIgOA/BkvY tw3VDZ3dK3y+V+IXw4r7SmqPNAJB1hGLB9/qwaU+yPw14yGEFsbH1Fpnmztyor+o1c 5nVeo4zcxJvDJoZCCyplIqQQb0sYEf4+JHU92CHI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730373AbgJOIgM (ORCPT ); Thu, 15 Oct 2020 04:36:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:32802 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729723AbgJOIgM (ORCPT ); Thu, 15 Oct 2020 04:36:12 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 576012075B; Thu, 15 Oct 2020 08:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602750971; bh=hP94CwWS7xvhTtF8wHiWx81RZLTLeMuk1epq5z2bU60=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Txd/JrrpLD6X5BUFspoeQ16zqYuMvFY/nGUubsShJbaDZD/vXpFyWkRVj1Db6IsFt sP2wBydRlaO/qSJTch7wm2jzfKeziqjJgYgqPtA5Z/sPQwdIOEOL6oree26WZRVPbN z3oI29eBZ5kFodoa2KvHQwD5FsU9Q5D0mDLAr5VA= Date: Thu, 15 Oct 2020 09:36:05 +0100 From: Will Deacon To: Sudarshan Rajagopalan Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Gavin Shan , Anshuman Khandual , Catalin Marinas , Mark Rutland , Logan Gunthorpe , David Hildenbrand , Andrew Morton , Steven Price Subject: Re: [PATCH v3] arm64/mm: add fallback option to allocate virtually contiguous memory Message-ID: <20201015083605.GA4537@willie-the-truck> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2020 at 05:51:23PM -0700, Sudarshan Rajagopalan wrote: > When section mappings are enabled, we allocate vmemmap pages from > physically continuous memory of size PMD_SIZE using > vmemmap_alloc_block_buf(). Section mappings are good to reduce TLB > pressure. But when system is highly fragmented and memory blocks are > being hot-added at runtime, its possible that such physically continuous > memory allocations can fail. Rather than failing the memory hot-add > procedure, add a fallback option to allocate vmemmap pages from > discontinuous pages using vmemmap_populate_basepages(). > > Signed-off-by: Sudarshan Rajagopalan > Reviewed-by: Gavin Shan > Reviewed-by: Anshuman Khandual > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Anshuman Khandual > Cc: Mark Rutland > Cc: Logan Gunthorpe > Cc: David Hildenbrand > Cc: Andrew Morton > Cc: Steven Price > --- > arch/arm64/mm/mmu.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Please can you fix the subject? I have three copies of "PATCH v3" from different days in my inbox. I know it sounds trivial, but getting these little things right really helps with review, especially when it's sitting amongst a sea of other patches. Thanks, Will