From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53FFFC433E7 for ; Thu, 15 Oct 2020 11:10:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECCD821D7F for ; Thu, 15 Oct 2020 11:10:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="IFGkPjap" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730526AbgJOLKE (ORCPT ); Thu, 15 Oct 2020 07:10:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729462AbgJOLKA (ORCPT ); Thu, 15 Oct 2020 07:10:00 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E262CC061755 for ; Thu, 15 Oct 2020 04:09:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=IjuE47JNwAqdmeGJ9n7G5r/lEe4gPS0RRx14k6uLMxI=; b=IFGkPjapHPybqD+b7xuUsOzpjK CMsyvn/PfizfG+JHWBE9d83Yw2bbg7WCtG4I2UCX4InNrH2o1uQfc05scmb9XTr5JW+/NrWdxNyig W1Ppv2MBgKoiWUf0tyMsYXSItgrxXtf3FYb2+IoKhyZwy3yPWVFEpvhuQ0Y+C/yoC47FiEAwlHg9a 0m7HFol6vOEILusJjL69q5bj0Gqnj4HB2XdfW9/0ZT8DQUfm6TygnY5e1Taw88GDXhLxXK5o9+mFk Suu2Lz19nbTTya9hIsWOQgYtknpK4IkjkEX621M1Isej8AVi/5LFyYGLB+0H+4fa3W1R6zD3xI2jb vkjUFERg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kT18e-0007wC-S9; Thu, 15 Oct 2020 11:09:41 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 1BA5A307943; Thu, 15 Oct 2020 13:09:37 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id B2417235F4454; Thu, 15 Oct 2020 13:09:36 +0200 (CEST) Message-ID: <20201015110924.338120198@infradead.org> User-Agent: quilt/0.66 Date: Thu, 15 Oct 2020 13:05:49 +0200 From: Peter Zijlstra To: tglx@linutronix.de, mingo@kernel.org Cc: linux-kernel@vger.kernel.org, bigeasy@linutronix.de, qais.yousef@arm.com, swood@redhat.com, peterz@infradead.org, valentin.schneider@arm.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vincent.donnefort@arm.com, tj@kernel.org, ouwen210@hotmail.com Subject: [PATCH v3 17/19] sched: Add migrate_disable() tracepoints References: <20201015110532.738127234@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org XXX write a tracer: - 'migirate_disable() -> migrate_enable()' time in task_sched_runtime() - 'migrate_pull -> sched-in' time in task_sched_runtime() The first will give worst case for the second, which is the actual interference experienced by the task to due migration constraints of migrate_disable(). Signed-off-by: Peter Zijlstra (Intel) --- include/trace/events/sched.h | 12 ++++++++++++ kernel/sched/core.c | 4 ++++ kernel/sched/deadline.c | 1 + kernel/sched/rt.c | 8 +++++++- 4 files changed, 24 insertions(+), 1 deletion(-) --- a/include/trace/events/sched.h +++ b/include/trace/events/sched.h @@ -646,6 +646,18 @@ DECLARE_TRACE(sched_update_nr_running_tp TP_PROTO(struct rq *rq, int change), TP_ARGS(rq, change)); +DECLARE_TRACE(sched_migrate_disable_tp, + TP_PROTO(struct task_struct *p), + TP_ARGS(p)); + +DECLARE_TRACE(sched_migrate_enable_tp, + TP_PROTO(struct task_struct *p), + TP_ARGS(p)); + +DECLARE_TRACE(sched_migrate_pull_tp, + TP_PROTO(struct task_struct *p), + TP_ARGS(p)); + #endif /* _TRACE_SCHED_H */ /* This part must be outside protection */ --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -1732,6 +1732,8 @@ void migrate_disable(void) return; } + trace_sched_migrate_disable_tp(p); + preempt_disable(); this_rq()->nr_pinned++; p->migration_disabled = 1; @@ -1764,6 +1766,8 @@ void migrate_enable(void) p->migration_disabled = 0; this_rq()->nr_pinned--; preempt_enable(); + + trace_sched_migrate_enable_tp(p); } EXPORT_SYMBOL_GPL(migrate_enable); --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -2245,6 +2245,7 @@ static void pull_dl_task(struct rq *this goto skip; if (is_migration_disabled(p)) { + trace_sched_migrate_pull_tp(p); push_task = get_push_task(src_rq); } else { deactivate_task(src_rq, p, 0); --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -1877,7 +1877,12 @@ static int push_rt_task(struct rq *rq, b struct task_struct *push_task = NULL; int cpu; - if (!pull || rq->push_busy) + if (!pull) + return 0; + + trace_sched_migrate_pull_tp(next_task); + + if (rq->push_busy) return 0; cpu = find_lowest_rq(rq->curr); @@ -2223,6 +2228,7 @@ static void pull_rt_task(struct rq *this goto skip; if (is_migration_disabled(p)) { + trace_sched_migrate_pull_tp(p); push_task = get_push_task(src_rq); } else { deactivate_task(src_rq, p, 0);